[DO NOT MERGE] optimize and clean bit functions #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested changes
Jan 2, 2025
| @@ -30,124 +30,106 @@ | |||
|
|
|||
| _LIBCUDACXX_BEGIN_NAMESPACE_STD | |||
|
|
|||
| _LIBCUDACXX_HIDE_FROM_ABI constexpr int __binary_clz2(uint64_t __x, int __c) | |||
There was a problem hiding this comment.
We cannot break user code that relies on those being constexpr in C++11, even if we have deprecated it
There was a problem hiding this comment.
agree. This is the reason I added [DO NOT MERGE]. The PR is intended for the next major update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(partially) Fixes #2239
Description
Optimize and cleanup the following functions:
Run-time optimizations are described in #2239.
Cleanup:
constexprto avoid several function instantiations_CCCL_NODISCARDto all functionsAdd__detailnamespaceDO NOT MERGE