Refactor limits and climits
#3221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Jan 2, 2025
Comment on lines
+329
to
+331
| #elif _CCCL_COMPILER(MSVC) | ||
| # define _CCCL_BUILTIN_NANSL(...) static_cast<long double>(__builtin_nans(__VA_ARGS__)) | ||
| #endif // _CCCL_CHECK_BUILTIN(builtin_nansl) |
There was a problem hiding this comment.
This wont work for older MSVC compiler < 19.34 which we still support, so I believe we need to add an elif branch for that
There was a problem hiding this comment.
I've tested it on godbolt and it seems to be working fine.
There was a problem hiding this comment.
Did you also check that they work with nvcc? Could be that there was some issue on that sid?
|
/ok to test |
miscco
approved these changes
Jan 3, 2025
| }; | ||
|
|
||
| _CCCL_DIAG_PUSH | ||
| _CCCL_DIAG_SUPPRESS_MSVC(4309) |
There was a problem hiding this comment.
Can we add a comment what that warning is about? we try to better document those cases
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements refactor of
limitsandclimitsmodules.Changes:
huge_val,nanandnansare defined in the standard way and moved to__cccl/builtin.hmodulelimitsandclimitsare implemented directly in the header instead ofdetail/libcxx/include/__cuda/climits_prelude.h's contents are moved toclimitsnumeric_limitsbit_castforinfandnanwhen no builtin is supported