Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix docs build 2 #1036

Merged
merged 3 commits into from
Nov 27, 2024
Merged

[BUGFIX] Fix docs build 2 #1036

merged 3 commits into from
Nov 27, 2024

Conversation

misi9170
Copy link
Collaborator

#1034 Fixed an issue with the docs building by pinning to a specific version of sphinxcontrib-autoyaml; in the meantime, @paulf81 opened an issue here, and now the good team there have already created a bugfix and new version, so this resets to an unpinned version of sphinxcontrib-autoyaml.

I'm at testing the build here, but assuming that passes, I will undo the forced docs building at this PR will be ready for review.

@misi9170 misi9170 changed the base branch from main to develop November 21, 2024 23:13
@misi9170
Copy link
Collaborator Author

Oof, never mind, this is already being done in #1035, sorry about that!

@misi9170 misi9170 closed this Nov 21, 2024
@paulf81
Copy link
Collaborator

paulf81 commented Nov 22, 2024

sorry!

@misi9170 misi9170 deleted the bugfix/fix-docs-2 branch November 22, 2024 14:35
@misi9170 misi9170 restored the bugfix/fix-docs-2 branch November 27, 2024 16:44
@misi9170 misi9170 reopened this Nov 27, 2024
@misi9170
Copy link
Collaborator Author

I am reopening this pull request as a temporary fix instead of #1035, since #1035 is incompatible with the currently-support python version 3.8. The intention will be to include this fix for FLORIS v4.2.1, and then use #1035 once we drop support for python version 3.8 in FLORIS v4.3.

@misi9170
Copy link
Collaborator Author

The temporary example docs build was successful. I've now reverted the changes to deploy-pages.yaml that were there just to force the build.

@misi9170 misi9170 marked this pull request as ready for review November 27, 2024 16:50
@misi9170 misi9170 requested a review from rafmudaf November 27, 2024 17:12
@misi9170 misi9170 merged commit d0c4813 into NREL:develop Nov 27, 2024
13 checks passed
@misi9170 misi9170 deleted the bugfix/fix-docs-2 branch November 27, 2024 17:21
@misi9170 misi9170 mentioned this pull request Nov 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants