-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all metadata to pyproject.toml #1026
Conversation
@rafmudaf , 3.8 is the only failing test, but 3.8 is also end of life: |
Changing the minimum Python version is kind of a big decision, so I wouldn't make that change just because a test is failing. However, whether to support Python 3.8 is a fair question. It may be worth asking for some community input. |
In this case, the error is because you specified Python >= 3.9, but the GitHub Actions job is testing Python 3.8. So the fix as it relates to the scope of this pull request is to use |
You're right, think I've fixed this now |
@paulf81 I was able to pip install this into a new conda environment and ran an example without issue. |
Move all metadata to pyproject.toml
Following examples such as:
https://packaging.python.org/en/latest/guides/modernize-setup-py-project/
This PR moves all metadata into pyproject.toml. Specifically: