New ht thcovmat #2126
New ht thcovmat #2126
Conversation
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
n3fit/src/n3fit/layers/DIS.py
Outdated
| fktable_arr, | ||
| dataset_name, | ||
| boundary_condition=None, | ||
| operation_name="NULL", |
There was a problem hiding this comment.
keyword arguments (kwargs) you don't use at this level, you don't have to specify. That's what **kwargs is for.
n3fit/src/n3fit/layers/DIS.py
Outdated
| This function is very similar to `compute_ht_parametrisation` in | ||
| validphys.theorycovariance.construction.py. However, the latter | ||
| accounts for shifts in the 5pt prescription. As of now, this function | ||
| is meant to work only for DIS NC data, using the ABMP16 result. |
There was a problem hiding this comment.
Maybe reference Eq. 6 of https://arxiv.org/pdf/1701.05838
n3fit/src/n3fit/layers/DIS.py
Outdated
| x = self.exp_kinematics['kin1'] | ||
| y = self.exp_kinematics['kin3'] | ||
| Q2 = self.exp_kinematics['kin2'] | ||
| N2, NL = 1#compute_normalisation_by_experiment(self.dataname, x, y, Q2) |
There was a problem hiding this comment.
Where is this function? Also I think you can do N2=NL=1, but not NL,N2=1
There was a problem hiding this comment.
The DIS.py is not in sync with the new way shifts are computed. Hence, that function that adds the shift in the theory predictions can be removed. I'll work on that later on, as we discussed. I should have deleted them.
| if (sam_t0 := file_content.get('sampling')) is not None: | ||
| SETUPFIT_FIXED_CONFIG['separate_multiplicative'] = sam_t0.get( | ||
| 'separate_multiplicative', False | ||
| ) |
There was a problem hiding this comment.
I don't remember why I implemented that...I think I can remove it
| # NOTE: from the perspective of the fit scalevar and ht uncertainties are the same since | ||
| # they are saved under the same name |
There was a problem hiding this comment.
Ah yes, we may want to start thinking of a long term solution as well. A tree of if-statments that grows exponentially for each source of theory uncertainty (scales, alphas, HT) is not super nice
| # NOTE: Same a `groups_data_by_process` in `construction.py` | ||
| procs_data = collect("data", ("group_dataset_inputs_by_process",)) |
There was a problem hiding this comment.
feel free to delete one (in master)
achiefa
force-pushed
the
new_ht_thcovmat
branch
2 times, most recently
from
28662e8 to
6b71fae
Compare
RoyStegeman
force-pushed
the
new_ht_thcovmat
branch
from
d75f1b9 to
8e1dc74
Compare
achiefa
force-pushed
the
new_ht_thcovmat
branch
from
8cd3726 to
3725aa4
Compare
This is a follow-up of #1865, rebased from the current master.