#322 Add PeriodicityModalScreen #341
Conversation
BatDroid
force-pushed
the
periodicity-modal
branch
from
56b7bb3 to
e729ad0
Compare
| @@ -9,12 +9,14 @@ type Props = { | |||
| text: string; | |||
| isSelected: boolean; | |||
| onPress: () => void; | |||
| touchableStyle?: StyleProp<ViewStyle>; | |||
There was a problem hiding this comment.
Please let's keep shared component style within the component as much as possible. If you want to add margin, you can add it inClickableTag.style.tsx - so it's easier to maintain.
There was a problem hiding this comment.
sure, I thought that maybe it's better not to modify other codes
| @@ -30,6 +31,11 @@ const AddEmissionNavigator = (): React.ReactElement => ( | |||
| options={BarCodeScanScreen.navigationOptions} | |||
| component={BarCodeScanScreen} | |||
| /> | |||
| <Stack.Screen | |||
There was a problem hiding this comment.
Should be place inside ModalNavigator because right now it's not opening as a modal
app/navigation/navigate.ts
Outdated
| @@ -23,6 +23,10 @@ const openInfoModal = (navigation) => (props = {}) => { | |||
| }); | |||
| }; | |||
|
|
|||
| const openPeriodicityModal = (navigation) => (props = {}) => { | |||
| navigation.push("PeriodicityModal", props); | |||
There was a problem hiding this comment.
Not tested, but I can guess something like this would work :
const openPeriodicityModal = (navigation) => (props = {}) => {
navigation.navigate("PeriodicityModal", {
screen: "PeriodicityModal",
params: props,
});
};
There was a problem hiding this comment.
having a function like this worked with the way I implemented it. adding it to ModalNavigator made it work strangely.(you can test it), besides I would have needed to call it like:
const openPeriodicityModal = (navigation) => (props = {}) => {
navigation.navigate("CommingSoon", { // because, coming soon is the first screen on navigator
screen: "PeriodicityModal",
params: props,
});
};| </View> | ||
| )} | ||
| <View style={styles.tagSection}> | ||
| <Text.H3>{t("PERIODICITY_MODAL_SCREEN_OCCURENES")}</Text.H3> |
There was a problem hiding this comment.
PERIODICITY_MODAL_SCREEN_OCCURRENCES
| onPress={() => { | ||
| setTimes(index + 1); | ||
| }} | ||
| text={`${index + 1} ${t(`PERIODICITY_MODAL_SCREEN_TIME${index > 0 ? "S" : ""}`)}`} |
There was a problem hiding this comment.
Unfortunately not all languages have the same system for plurial (1 gang/2 gange in danish) so maybe this would work better :
${index > 0 ? t("PERIODICITY_MODAL_SCREEN_TIME"): t("PERIODICITY_MODAL_SCREEN_TIMES")}
| dayIndex: number; | ||
| nameKey: keyof TranslationKeys; | ||
| }[] = [ | ||
| { dayIndex: 2, nameKey: "MONDAY" }, |
There was a problem hiding this comment.
Since the days will be use later on, you can put them in app/utils/ui/translations/en.json and use them like this : UI_MONDAY
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "INFO_MODAL_SCREEN_METHODOLOGY": "Metodología" | |||
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "INFO_MODAL_SCREEN_METHODOLOGY": "Methodologie" | |||
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "INFO_MODAL_SCREEN_METHODOLOGY": "Metodologi" | |||
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "INFO_MODAL_SCREEN_METHODOLOGY": "方法" | |||
|
hope changes are acceptable & I can start working on other issues. |
|
@BatDroid yes, no problem, just email me your address and I will send you a bunch of stickers 🙂 |
✅ I have read the contributing file
Summary
Adding screen as explained in #322
Changelog
Adding Periodicity screen which can be opened by calling
navigator.openPeriodicityModal();.(the button which leads the user to it is not added yet, I'm willing to work on that issue).
Demo