Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Periodicity screen #322

Closed
3 tasks done
Tracked by #254
PierreBresson opened this issue Sep 24, 2021 · 5 comments
Closed
3 tasks done
Tracked by #254

Periodicity screen #322

PierreBresson opened this issue Sep 24, 2021 · 5 comments
Assignees
@BatDroid
Labels
🆕 Feature New feature - approved by the team 🎁 Stickers Free set of 3 stickers if you complete the task

Comments

@PierreBresson
Copy link
Member

PierreBresson commented Sep 24, 2021 •
edited
Loading

  • create screen
  • display ClickableTags components see ClickableTag component #324
  • return user input values to Add Emission screen when user press confirm / or store input values in redux

Periodicity
Selected-1
Selected
@PierreBresson PierreBresson mentioned this issue Sep 24, 2021
Open
4 tasks
@PierreBresson PierreBresson added hacktoberfest https://hacktoberfest.digitalocean.com/ 🆕 Feature New feature - approved by the team labels Sep 24, 2021
@PierreBresson PierreBresson added the 🎁 Stickers Free set of 3 stickers if you complete the task label Oct 5, 2021
@BatDroid
Copy link
Contributor

I can work on this :)
just tell me from where the user can reach this screen (which I should create) :)

@PierreBresson
Copy link
Member Author

@BatDroid thanks, I've assigned you :)
The user can reach that screen from Add emission screen when clicking on Non-recurring (see #254) and it should open as a modal - that's why there is cross button to close it)

@BatDroid
Copy link
Contributor

@PierreBresson (I'll make this screen till you reply anyway) If I'm getting it correctly I suppose #254 needs to be done first. I mean, It seems in #254 the button which leads the user to the Periodicity screen happens. right?
If yes then I suppose it's better that I work on both of them.

@PierreBresson
Copy link
Member Author

Not really, #254 is just the listing of all the issues needed to complete the feature periodicity. Some work was done in #329 but it needs to be refactored into a component.
Yes, clicking on Non-recurring in #254 is opening this periodicity screen

@BatDroid
Copy link
Contributor

@PierreBresson I see, Then feel free to assign #315 & #321 to me as well.

BatDroid added a commit to BatDroid/nmf-app that referenced this issue Oct 19, 2021
@BatDroid
NMF-earth#322 Add PeriodicityModalScreen
56b7bb3
@BatDroid BatDroid mentioned this issue Oct 19, 2021
Merged
BatDroid added a commit to BatDroid/nmf-app that referenced this issue Oct 19, 2021
@BatDroid
NMF-earth#322 Add PeriodicityModalScreen
e729ad0
PierreBresson pushed a commit that referenced this issue Oct 22, 2021
@BatDroid
#322 Add PeriodicityModalScreen (#341)
9c9948e 
* #322 Add PeriodicityModalScreen

* Add requested changes

* Add updated snapshots
@PierreBresson PierreBresson removed the hacktoberfest https://hacktoberfest.digitalocean.com/ label Nov 1, 2021
PierreBresson added a commit that referenced this issue Nov 27, 2021
@PierreBresson
#322
03fd375
@PierreBresson PierreBresson mentioned this issue Nov 27, 2021
Merged
PierreBresson added a commit that referenced this issue Nov 27, 2021
@PierreBresson
#322 (#350)
e04beaf 
feat: return user input to Add Emission screen when user press confirm on Periodicity screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BatDroid BatDroid

Labels
🆕 Feature New feature - approved by the team 🎁 Stickers Free set of 3 stickers if you complete the task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PierreBresson @BatDroid