MCR-3229 enable PMD rule LooseCoupling #2353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 139 out of 154 changed files in this pull request and generated no comments.
Files not reviewed (15)
- mycore-base/src/main/java/org/mycore/common/MCRMailer.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/content/util/MCRRestContentHelper.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/access/MCRAccessCacheHelper.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/access/mcrimpl/MCRAccessStore.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/content/transformer/MCRContentTransformerFactory.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/content/util/Range.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/events/MCREventManager.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/log/MCRTableMessage.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/MCRUtils.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/config/MCRConcurrentHashMap.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/events/MCREvent.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/config/MCRConfigurationInputStream.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/events/MCRShutdownHandler.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/common/config/MCRConfiguration2.java: Evaluated as low risk
- mycore-base/src/main/java/org/mycore/access/mcrimpl/MCRAccessDefinition.java: Evaluated as low risk
Mewel
requested changes
Jan 15, 2025
| @@ -143,7 +143,7 @@ public String toString() { | |||
| * It only used by {@link #mark} and {@link #resetCloseables()}. | |||
| */ | |||
| private record MCRShutdownHandlerState(boolean shuttingDown, | |||
| ConcurrentSkipListSet<MCRShutdownHandler.Closeable> requests) { | |||
| java.util.NavigableSet<MCRShutdownHandler.Closeable> requests) { | |||
mycore-iview2/src/main/java/org/mycore/iview2/services/MCRTilingQueue.java
Show resolved
Hide resolved
yagee-de
force-pushed
the
issues/MCR-3229-enable-pmd-rule-category-java-bestpractices-xml-loose-coupling
branch
from
a140dd3 to
01f5376
Compare
yagee-de
force-pushed
the
issues/MCR-3229-enable-pmd-rule-category-java-bestpractices-xml-loose-coupling
branch
from
01f5376 to
79a7414
Compare
yagee-de
force-pushed
the
issues/MCR-3229-enable-pmd-rule-category-java-bestpractices-xml-loose-coupling
branch
from
458a424 to
33a4c45
Compare
Mewel
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.
This pull request focuses on refactoring the codebase to use more generic collection interfaces (
ListandMap) instead of specific implementations (ArrayListandHashMap). This change improves code flexibility and readability.Also exceptions to the PMD rule where configured, were specific subclasses provide additional functionality beside their collection functionality.
ArrayListit will beListafter the merge, so minor changes to the code will be necessary.