MCR-3214 Add handlings for non validatable pdf documents #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagee-de
requested changes
Oct 28, 2024
Comment on lines
84
to
85
| results.put(dir.relativize(file).toString(), new ValidationErrorResult()); | ||
|
|
There was a problem hiding this comment.
Details (cause, stacktrace) of Exception are lost here. Better way is to put the Exception into the map and serialize at least the cause into the Document. You could use a record to old ValidationResult or Exception and use it as a map value.
yagee-de
requested changes
Nov 19, 2024
Comment on lines
172
to
201
| while (!exceptionsQueue.isEmpty()) { | ||
| Throwable currentException = exceptionsQueue.poll(); | ||
| Element exceptionElement = document.createElement("exception"); | ||
|
|
||
| Element classElement = document.createElement("class"); | ||
| classElement.setAttribute("name", currentException.getClass().getName()); | ||
| exceptionElement.appendChild(classElement); | ||
|
|
||
| if (currentException.getMessage() != null) { | ||
| Element messageElement = document.createElement("message"); | ||
| messageElement.setAttribute("message", currentException.getMessage()); | ||
| exceptionElement.appendChild(messageElement); | ||
| } | ||
|
|
||
| Element stackTraceElement = document.createElement("stackTrace"); | ||
| for (StackTraceElement ste : currentException.getStackTrace()) { | ||
| Element frameElement = document.createElement("frame"); | ||
| frameElement.setAttribute("text", ste.toString()); | ||
| stackTraceElement.appendChild(frameElement); | ||
| } | ||
| exceptionElement.appendChild(stackTraceElement); | ||
|
|
||
| exceptionElementList.add(exceptionElement); | ||
|
|
||
| exceptionsQueue.addAll(List.of(currentException.getSuppressed())); | ||
| if (currentException.getCause() != null && | ||
| !currentException.getCause().equals(currentException)) { | ||
| exceptionsQueue.add(currentException.getCause()); | ||
| } | ||
| } |
There was a problem hiding this comment.
This should be a hierarchy of elements not a list. We need to know what are causes and what a suppressed exception of which exception
yagee-de
requested changes
Jan 20, 2025
Comment on lines
144
to
148
| List<Element> exceptions = createExceptionElements(document, resultEntry.exception()); | ||
| Element exceptionElements = document.createElement("exceptions"); | ||
| for (Element exception : exceptions) { | ||
| exceptionElements.appendChild(exception); | ||
| } |
There was a problem hiding this comment.
You hand over an Exception and receive a List of Exception Elements? I think only one exception could be thrown finally and caught. So no need for "" or a List return type.
Comment on lines
178
to
180
| if (currentException == null || exceptionsQueue.contains(currentException)) { | ||
| return exceptionElementList; | ||
| } |
There was a problem hiding this comment.
When you have a tree, how can an exception be in there twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.