Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add V3-RC validation #104

Merged
merged 13 commits into from
Jun 29, 2023
Merged

Add V3-RC validation #104

merged 13 commits into from
Jun 29, 2023

Conversation

tdelmas
Copy link
Collaborator

@tdelmas tdelmas commented Jun 15, 2023

Continuation of #98

@netlify
Copy link

netlify bot commented Jun 15, 2023 •
edited
Loading

✅ Deploy Preview for gbfs-validator ready!

Name Link
🔨 Latest commit 7e7bd7b
🔍 Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/649d37b159b61d0008c91e71
😎 Deploy Preview https://deploy-preview-104--gbfs-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PierrickP
Copy link
Collaborator

PierrickP commented Jun 15, 2023 •
edited
Loading

Replace #98 and fix #92 (not yet)

@richfab richfab requested a review from davidgamez June 21, 2023 15:23
richfab
richfab reviewed Jun 21, 2023
View reviewed changes
gbfs-validator/versions/schemas/.github/workflows/issues-to-project.yml Outdated

This comment was marked as duplicate.

Sign in to view

richfab
richfab approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@richfab richfab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Really well done @tdelmas!

Thank you for this very valuable contribution to the validator 👏

Please sync with @davidgamez and @josee-sabourin for the merge as I'm off tomorrow (Friday June 23rd). Thank you

@PierrickP
Copy link
Collaborator

Can we merge ? :)

@tdelmas tdelmas mentioned this pull request Jun 26, 2023
Closed
davidgamez
davidgamez reviewed Jun 26, 2023
View reviewed changes
gbfs-validator/gbfs.js Outdated Show resolved Hide resolved
gbfs-validator/gbfs.js Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@richfab richfab mentioned this pull request Jun 26, 2023
Closed
tdelmas added 8 commits June 28, 2023 15:14
@tdelmas
Squashed 'gbfs-validator/versions/schemas/' changes from 5273f96..22b…
af854e3 
…058d

22b058d fix: incorrect spec for "languages" property in system_information.json (MobilityData#90)
e9d891b Refer to later versions in gbfs_versions.json (MobilityData#87)
fbd3ced Add v3.0 to v3.0-RC schemas (MobilityData#88)
ef0d9a6 Fix schemas for v3.0-RC (MobilityData#85)
2b6ad1e FIX: replaces name field with localized string (MobilityData#82)
abe71f2 Fix invalid json, no trailing commas (MobilityData#83)
f43170e V3.0-RC Schemas  (MobilityData#79)
680df70 Update pr-to-project.yml
c2c30a2 Typo fix in geofencing_zones.json (MobilityData#78)
c9be765 Create pr-to-project.yml
0a17875 Create issues-to-project.yml
30e5a3a Update README.md

git-subtree-dir: gbfs-validator/versions/schemas
git-subtree-split: 22b058dc4a358baf451e006cde74775075929b3d
@tdelmas
remove dot files in schemas
8639c25 
Signed-off-by: Tom <[email protected]>
@tdelmas
v3-RC validation
f069eee 
Signed-off-by: Tom <[email protected]>
@tdelmas
Remove unused file
2689efb 
Signed-off-by: Tom <[email protected]>
@tdelmas
Add serverOpts required in Windows
5319004 
Signed-off-by: Tom <[email protected]>
@tdelmas
Fix typo recommended
055c48a 
Signed-off-by: Tom <[email protected]>
@tdelmas
update test for 3.0-RC , 3.0 and upcoming minor versions
711e3b8 
Signed-off-by: Tom <[email protected]>
@tdelmas
fix after rebase
b2630a6 
Signed-off-by: Tom <[email protected]>
@tdelmas
Recommended.
d50e854 
Signed-off-by: Tom <[email protected]>
@tdelmas
Copy link
Collaborator Author

tdelmas commented Jun 28, 2023

Thank you all for your reviews.

I had to force-push after a chaotic rebase due to the git subtrees. Sorry about that. It should only impact the git history and hopefully nothing else.

tdelmas added 2 commits June 29, 2023 09:49
@tdelmas
Squashed 'gbfs-validator/versions/schemas/' changes from 22b058d..5f1…
d057d2b 
…2243

5f12243 Patch manifest.json (MobilityData#91)

git-subtree-dir: gbfs-validator/versions/schemas
git-subtree-split: 5f12243d5735a608eef697212a627b9090eea31a
@tdelmas
Merge commit 'd057d2b521cc8528bd218e226fffb0c6dc42b821' into v3-RC-patch
7e7bd7b
@richfab
Copy link
Contributor

richfab commented Jun 29, 2023

Thank you @tdelmas and @PierrickP for this huge contribution 👏
Merging now.

@richfab richfab merged commit e3d5f08 into MobilityData:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richfab richfab richfab approved these changes

@PierrickP PierrickP PierrickP approved these changes

@davidgamez davidgamez davidgamez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdelmas @PierrickP @richfab @davidgamez