fix tcp read unstable stuck

[cs8425]

fix tcp read sometimes stuck on android platform.
cause by sometimes sendReceiveEvent() are un-ordered.

sendReceiveEvent(new PluginResult(Status.OK, info));
sendReceiveEvent(new PluginResult(Status.OK, recvBytes));

[mcelrath]

Can you explain your logic here? You're calling readyToRead at least twice for each packet. Once should be enough, if it needs to be called at all.

I find that not calling readyToRead at all seems to solve #26.

[cs8425]

fix the same issue on android as @mcelrath at #27 .

exec(null, readyToRead, 'ChromeSocketsTcp', 'readyToRead', [socketId])
Call js function readyToRead only when exec failed, not twice for each packet.
https://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/#the-javascript-interface
Just make sure native readyToRead will be called once.

[mcelrath]

I found the bug with steam corruption in the master branch, without your patch. AFAICT it is not necessary to call `readyToRead` at all on Android. (At least, my patch without it works perfectly) Why do you call it?

…

On March 4, 2017 10:24:26 AM EST, cs8425 ***@***.***> wrote: fix the same issue on android as @mcelrath at #27 . `exec(null, readyToRead, 'ChromeSocketsTcp', 'readyToRead', [socketId])` Call js function `readyToRead` only when `exec` **failed**, not twice for each packet. Just make sure native `readyToRead` will be called once. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #25 (comment) !DSPAM:58badc35191181728019888!

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[cs8425]

@mcelrath
If not call native readyToRead,
nio will never go to read any new data from socket (SelectionKey.OP_READ has been removed),
but you still can sent data (can write, can't read).
You can look some java nio program document about channels and selector.
http://tutorials.jenkov.com/java-nio/selectors.html
And try not to call native readyToRead on a bidirectional, keep sending tcp socket, then you will know what I said.

ps. make sure the code has been updated, check by unzip the output apk file.

[mcelrath]

Try my patch... I am able to read and write...

…

On March 5, 2017 10:47:31 AM EST, cs8425 ***@***.***> wrote: @mcelrath If not call native `readyToRead`, nio will never go to read any new data from socket, but you still can sent data (can write, can't read). You can try it on a bidirectional, keep sending tcp socket, then you will know what I said. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #25 (comment) !DSPAM:58bc331c63431952020848!

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[cs8425]

@mcelrath
your patch can't work...
as I said, never go to read any new data!
only signature and /assets/www/plugins/cordova-plugin-chrome-apps-sockets-tcp/sockets.tcp.js are different.
you can unzip/disassembling apk file to check it.

app source: https://github.com/cs8425/tcp-test-app
pre-build apk
mine: google drive
your: google drive

[mcelrath]

Yes, that's intended. The fix is entirely in sockets.tcp.js... Just diff it.

…

On March 7, 2017 2:31:39 PM EST, cs8425 ***@***.***> wrote: @mcelrath your patch can't work... only signature and `/assets/www/plugins/cordova-plugin-chrome-apps-sockets-tcp/sockets.tcp.js` are different. you can unzip/disassembling apk file to check it. app source: [https://github.com/cs8425/tcp-test-app](https://github.com/cs8425/tcp-test-app) pre-build apk mine: [google drive](https://drive.google.com/file/d/0B-ud10kmI-kSS0d3czNyRE9wQ00/view?usp=sharing) your: [google drive](https://drive.google.com/file/d/0B-ud10kmI-kSRVFOYVlDUndaeWM/view?usp=sharing) -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #25 (comment) !DSPAM:58bf0aa3211331626613455!

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.