Use Yarn caching in GitHub Actions #19662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Builds ready [7030355]
Page Load Metrics (1607 ± 52 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #19662 +/- ##
========================================
Coverage 70.79% 70.79%
========================================
Files 988 988
Lines 38365 38365
Branches 10041 10041
========================================
Hits 27160 27160
Misses 11205 11205 |
Gudahtt
force-pushed
the
use-nvmrc-in-github-action-workflows
branch
from
92bb191 to
9c8da5a
Compare
Gudahtt
force-pushed
the
github-actions-yarn-caching
branch
from
7030355 to
0fa2020
Compare
Builds ready [0fa2020]
Page Load Metrics (1981 ± 71 ms)
Bundle size diffs
|
Gudahtt
force-pushed
the
github-actions-yarn-caching
branch
from
0fa2020 to
1a975c6
Compare
GitHub actions that install dependencies will now also cache those dependencies using the standard strategy for Yarn (which is to hash the lockfile). This matches the module template (see MetaMask/metamask-module-template#145 for details). This should have no functional impact except that this action will run faster when dependencies are unchanged.
Gudahtt
force-pushed
the
github-actions-yarn-caching
branch
from
1a975c6 to
49b3968
Compare
Builds ready [49b3968]
Page Load Metrics (1766 ± 66 ms)
Bundle size diffs
|
FrederikBolding
approved these changes
Jun 26, 2023
metamaskbot
added
the
release-10.34.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The only GitHub action to install dependencies will now also cache those dependencies using the standard strategy for Yarn (which is to hash the lockfile).
This matches the module template (see MetaMask/metamask-module-template#145 for details).
This should have no functional impact except that this action will run faster when dependencies are unchanged.
Manual Testing Steps
None; this should have no functional impact. The only affected workflow is the fitness functions check, which should work the same as before.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.