Fix bug decoding SlackPlainText #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rampion
commented
Dec 20, 2023
| text <- obj .: "text" | ||
| pure . SlackPlainText . SlackText $ lines text | ||
| "mrkdwn" -> do | ||
| text <- obj .: "text" | ||
| pure . SlackMarkdownText . SlackText $ lines text | ||
| _ -> fail "Unknown SlackTextObject type, must be one of ['text', 'mrkdwn']" | ||
| _ -> fail "Unknown SlackTextObject type, must be one of ['plain_text', 'mrkdwn']" |
There was a problem hiding this comment.
Note how previously the ToJSON instance encoded SlackPlainText values using "type" .= "plain_text" but FromJSON didn't accept that type.
rampion
force-pushed
the
fix-slack-text-object-from-json
branch
from
4b4dc7a to
de79452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SlackPlainTextconstructor ofSlackTextObject'sToJSONandFromJSONinstances disagreed on whether its type should be"plain_text"or"text".This failure to decode when the type was set to
"plain_text"caused a bug when interacting with slack.