Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove check doca validation #1296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rollandf
Copy link
Member

@rollandf rollandf commented Jan 23, 2025

Reading secrets is not allowed in PRs

Make target still available for local check

@coveralls
Copy link
Collaborator

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12932806646

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 60.072%

Files with Coverage Reduction New Missed Lines %
controllers/nicclusterpolicy_controller.go 1 79.08%
controllers/macvlannetwork_controller.go 2 86.25%
Totals Coverage Status
Change from base Build 12930963865: 0.3%
Covered Lines: 3349
Relevant Lines: 5575

💛 - Coveralls

@rollandf rollandf added the on hold This enhancement is currently on hold pending additional clarification and evaluation label Jan 23, 2025
@rollandf
Copy link
Member Author

rollandf commented Jan 23, 2025

DNM: Debugging doca-driver check

@rollandf rollandf force-pushed the test-doca-validation branch from 2f7f0d0 to 0a97c60 Compare January 23, 2025 15:30
- Reading secrets is not allowed in PRs

Make target still available for local check

Signed-off-by: Fred Rolland <[email protected]>
@rollandf rollandf force-pushed the test-doca-validation branch from 0a97c60 to 6da90e4 Compare January 23, 2025 15:44
@rollandf rollandf removed the on hold This enhancement is currently on hold pending additional clarification and evaluation label Jan 23, 2025
@rollandf rollandf requested review from maze88 and heyvister1 January 23, 2025 15:44
@rollandf rollandf changed the title chore: check doca validation chore: remove check doca validation Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants