Fix configure arg enable #1037
Open
Fix configure arg enable #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AC_ARG_ENABLE() autoconf macro is sometimes incorrect in mstflint.
See [1].
A construct such as:
AC_ARG_ENABLE(fw-mgr,
[ --enable-fw-mgr Enable compiling mstfwmanager tool and features],
[enable_fw_mgr="yes"],
[enable_fw_mgr="no"])
sets the "action-if-given" to always forces the feature to "yes".
This can lead to the inverse of the desired effect. That is, calling:
./configure --disable-fw-mgr
or
./configure --enable-fw-mgr=no
will result to enable the feature. The only way to actually disable the
feature is to currently call "./configure" without the argument, to use
the default value set to "no".
This commit fixes the issue by consistently making all
"action-if-given" to use the quoted "$enableval".
[1] https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#Package-Options
Signed-off-by: Julien Olivain <[email protected]>
Several AC_ARG_ENABLE() usage are not using AS_HELP_STRING() to
format the argument help strings. This is resulting in incorrect
indentation of the output produced by calling:
./configure --help
This commit fixes the issue by adding the missing AS_HELP_STRING().
Signed-off-by: Julien Olivain <[email protected]>
|
LGTM |
|
Please @ogalbxela , can you consider this topic too ? |
|
Please @ogalbxela ; why is it so slow to merge few obvious lines ? It does not seem to be an active open source project per se. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AC_ARG_ENABLE() autoconf macro is sometimes incorrect in mstflint.
See:
https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#Package-Options
A construct such as:
sets the "action-if-given" to always forces the feature to "yes".
This can lead to the inverse of the desired effect. That is, calling:
or
will result to enable the feature. The only way to actually disable the
feature is to currently call "./configure" without the argument, to use
the default value set to "no".
This commit fixes the issue by consistently making all
"action-if-given" to use the quoted "$enableval".
Also, a second commit fixes minor "./configure --help" indentation issues by using AS_HELP_STRING().