Skip draining controller pod #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykulazhenkov
approved these changes
Jan 22, 2025
rollandf
approved these changes
Jan 22, 2025
Pull Request Test Coverage Report for Build 12905080828Details
💛 - Coveralls |
during drain operation the controller should skip its own pod to support single-node case where a single node is both control plane and worker. we achieve this by adding an implicit pod selector label to the drain request. Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
support-single-node
branch
from
0348f19 to
84a04f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during drain operation the controller should
skip its own pod to support single-node case
where a single node is both control plane and worker.
we achieve this by adding an implicit pod selector label to the drain request.