issue: 4231240 Revive gtest for doca_xlio_vNext #283
Conversation
tomerdbz
changed the title
tomerdbz
force-pushed
the
4231240_gtest_for_doca
branch
8 times, most recently
from
ac30a78 to
04caeeb
Compare
tomerdbz
force-pushed
the
4231240_gtest_for_doca
branch
5 times, most recently
from
5bec7d0 to
7665a82
Compare
|
bot:retest |
tests/gtest/xliod/xliod_base.cc
Outdated
| version[2] = PRJ_LIBRARY_RELEASE; | ||
| version[3] = PRJ_LIBRARY_REVISION; | ||
| data.ver = (PRJ_LIBRARY_MAJOR << 12) | (PRJ_LIBRARY_MINOR << 8) | (PRJ_LIBRARY_RELEASE << 4) | | ||
| PRJ_LIBRARY_REVISION; |
There was a problem hiding this comment.
please notice , original code gives 8 bits (1byte) per category (thus range of 0 to 255 each).
the new code gives only 4 bits per category ( thus range of 0-15).
our current library minor is 40 , thus requires 8 bits.
either keep the original (i think it's more readable, but you are the master), or increase the offsets to be 8 bits instead of 4
tests/gtest/xliod/xliod_init.cc
Outdated
| version[2] = PRJ_LIBRARY_RELEASE; | ||
| version[3] = PRJ_LIBRARY_REVISION; | ||
| m_data.ver = (PRJ_LIBRARY_MAJOR << 12) | (PRJ_LIBRARY_MINOR << 8) | | ||
| (PRJ_LIBRARY_RELEASE << 4) | PRJ_LIBRARY_REVISION; |
There was a problem hiding this comment.
please notice , original code gives 8 bits (1byte) per category (thus range of 0 to 255 each).
the new code gives only 4 bits per category ( thus range of 0-15).
our current library minor is 40 , thus requires 8 bits.
either keep the original (i think it's more readable, but you are the master), or increase the offsets to be 8 bits instead of 4
|
|
||
| # Verify keep_alive IPv6 | ||
| eval "${sudo_cmd} $timeout_exe env GTEST_TAP=2 LD_PRELOAD=$gtest_lib $gtest_app $gtest_opt_ipv6 --gtest_filter=keep_alive* --gtest_output=xml:${WORKSPACE}/${prefix}/test-keepalive_ipv6.xml" | ||
| eval "${sudo_cmd} $timeout_exe env GTEST_TAP=2 XLIO_MEM_ALLOC_TYPE=ANON XLIO_DOCA_RX=1 XLIO_DOCA_TX=1 LD_PRELOAD=$gtest_lib $gtest_app $gtest_opt --gtest_filter=keep_alive* --gtest_output=xml:${WORKSPACE}/${prefix}/test-keepalive_ipv4.xml" |
There was a problem hiding this comment.
do you mean to only run --gtest_filter=keep_alive* tests?
you have no intention of running the others?
contrib/jenkins_tests/gtest.sh
Outdated
| @@ -29,6 +29,8 @@ function do_get_addrs() | |||
| echo $gtest_ip_list | |||
| } | |||
|
|
|||
| gtest_ip_remote=$(ip -f inet addr show eth0 | awk '/inet / {print $2}' | cut -d/ -f1) | |||
There was a problem hiding this comment.
why eth0? how to guarantee the existing of eth0?
There was a problem hiding this comment.
This will always exist in our k8s environment, not sure about other places, we should probably make sure we are in k8s/Docker env before setting this up
There was a problem hiding this comment.
changed according to dpressle comment :) Thanks!
"lets put this line only where we set ip addresses for net1/2 (which is also only true for k8s)"
There was a problem hiding this comment.
So i think you should move it somewhere after line 34 (the non manual run which is CI run) because its always true there
tomerdbz
force-pushed
the
4231240_gtest_for_doca
branch
3 times, most recently
from
5c6acdc to
7dc9536
Compare
|
@tomerdbz it seems that all gtests that do actual connection or data exchange are skipped. It looks as significant degradation in basic verification |
|
Hi @igor-ivanov, Currently DOCA do not support fork, this is why we suppress the server client test for now in gtest. |
contrib/jenkins_tests/gtest.sh
Outdated
| @@ -29,6 +29,8 @@ function do_get_addrs() | |||
| echo $gtest_ip_list | |||
| } | |||
|
|
|||
| gtest_ip_remote=$(ip -f inet addr show eth0 | awk '/inet / {print $2}' | cut -d/ -f1) | |||
There was a problem hiding this comment.
So i think you should move it somewhere after line 34 (the non manual run which is CI run) because its always true there
does XLIO support NGINX w/o fork? |
tomerdbz
force-pushed
the
4231240_gtest_for_doca
branch
from
7dc9536 to
d3c1f77
Compare
The gtest suite doesn't run for doca_xlio_vNext. while the fork related tests will fail there's no real reason not to run the other tests. Signed-off-by: Tomer Cabouly <[email protected]>
tomerdbz
force-pushed
the
4231240_gtest_for_doca
branch
from
d3c1f77 to
798e814
Compare
in NGINX we have a master process so grissik did a W/A to make it work. |
The gtest suite doesn't run for doca_xlio_vNext.
while the fork related tests will fail
there's no real reason not to run the other tests.
Description
What
gtest suite for doca_xlio_vNext.
Why ?
Justification for the PR. If there is existing issue/bug please reference.
How ?
It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.
Change type
What kind of change does this PR introduce?
Check list