Sys ctl to env param #277
Open
Sys ctl to env param #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasharRadya
force-pushed
the
sys_ctl_to_env_param
branch
2 times, most recently
from
765614a to
5da4add
Compare
|
bot:retest |
1 similar comment
|
bot:retest |
|
After discussion with Igor, we need to consider control parameters. Such as bindipv6only. These parameters are better to set the same as Kernel as these affect app behavior rather than performance. Lets discuss how we should proceed with them. |
BasharRadya
force-pushed
the
sys_ctl_to_env_param
branch
3 times, most recently
from
9d7120a to
98d8a67
Compare
|
bot:retest |
|
bot:retes |
|
bot:retest |
BasharRadya
force-pushed
the
sys_ctl_to_env_param
branch
from
98d8a67 to
9e5454a
Compare
|
bot:retest |
3 similar comments
|
bot:retest |
|
bot:retest |
|
bot:retest |
BasharRadya
force-pushed
the
sys_ctl_to_env_param
branch
2 times, most recently
from
c039e4a to
5546949
Compare
Refactored the logic to retrieve system parameters via environment variables instead of relying on system control (`sysctl`) parameters. Improved compatibility with containerized and runtime-configurable environments. Signed-off-by: Bashar Abdelgafer <[email protected]>
BasharRadya
force-pushed
the
sys_ctl_to_env_param
branch
from
5546949 to
10be792
Compare
|
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Read system control parameters from environment variables
Configure TSO and LRO default to ON
What
Subject: what this PR is doing in one line.
Why ?
better control of sys vars in virtual and container environment
How ?
read from enviorn variables instead of sys ctl
Change type
What kind of change does this PR introduce?
Check list