Fix by replacing tau_franes with tau_times #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
lilyminium
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
LGTM. Thanks for the fix @pgbarletta!
FYI, if some time has passed and you don't get a response, please do feel free to ping me or Rocco directly -- it can be easy for things to slip through the cracks during busy times! (I was just at back-to-back conferences and getting covid yet again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344
The user pointed out exactly why this notebook worked even though it was conceptually wrong.
📚 Documentation preview 📚: https://mdanalysisuserguide--346.org.readthedocs.build/en/346/