Gh 788 QA testing2 #564
Open
Gh 788 QA testing2 #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GH-781: experimenting with a test utility * GH-781: task might be complete now * GH-781: debugging for windows * GH-781: trying to satisfy Win * GH-781: clippy * GH-781: removed bad solution for issue that now a new card was written for * GH-781: cargo.toml change * GH-781: review answered --------- Co-authored-by: Bert <[email protected]>
* fixed tests failing on Bert's computer * formatting * remove commented out code * change .clone() to reference * fixed test for windows in actions: tilde_in_config_file_path_from_commandline_and_args_uploaded_from_config_file * target_os for dirs crate used only on windows test * implementing Bert's review comments - change DirsWrapperMock to DirsWrapperReal and simplifying home_dir creation * fixing windows data-directory assertion in test tilde_in_config_file_path_from_commandline_and_args_uploaded_from_config_file * fixing home dir assertion for windows * add condition to use of dirs crate only for windows * fixing config toml for windows test tilde_in_config_file_path_from_commandline_and_args_uploaded_from_config_file * fixed windows test * formatting * fixed tilde tests for windows * remove unnecesary function for finding project root, use of current dir for DirsWrapperMock * adjusting name of test and removing commented out code
* GH-791: fixed * GH-791: put some explanatory lines back --------- Co-authored-by: Bert <[email protected]>
* GH-797: minor docs modification * GH-797: some TODOs * GH-797: add the definitions for min hops and gas price. * GH-797: remove the markdown code container
* GH-728: add the TODOs * GH-728: removed the code of the NewPasswordMessage * GH-728: use ConfigurationChangeMessage while changing password * GH-728: rename configuration_change_msg_sub_opt to update_min_hops_sub_opt * GH-728: rename new_password_subs to update_password_subs * GH-728: fix wrong name for the actor message * GH-728: send ConfigurationChangeMessage to other actors too * GH-728: add a TODO * GH-728: rename to _opt * GH-728: implement handler for ConfigurationChange::UpdatePassword inside Neighborhood * GH-728: add TODO to implement handler for ConfigurationChange::UpdatePassword inside BlockchainBridge * GH-728: add TODO to implement handler for ConfigurationChange::UpdatePassword inside Accountant * GH-728: create new struct for UpdatePasswordSubs * GH-728: add the new TODO * GH-728: send a ConfigurtionChangeMessage when the consuming wallet is generated * GH-728: add a test for the panic case * GH-728: some refactor changes in configurator.rs * GH-728: test drive the case when the wallet is recovered * GH-728: fix some of the tests * GH-728: fix the remaining 2 failing tests * GH-728: reorder fields * GH-728: the received ConfigurationChangeMessage is properly handled * GH-728: update the password when necessary * GH-728: add a todo * GH-728: add the ability to synchronise password * GH-728: add ability for accountant to handle an unexpected configuration change msg * GH-728: improve tests for handling ConfigurationChangeMessage in accountant * GH-728: minor renames * GH-728: remove finished TODO and formatting changes * GH-728: add test in blockchain bridge for ConfigurationChangeMessage * GH-728: add test in neighborhood for ConfigurationChangeMessage * GH-728: remove useless tests * GH-728: revive an old test * GH-728: improve todo * GH-728: test rename and add more TODOs * GH-728: cleanup and creation of new file configuration_change_subs.rs * GH-728: minor refactor and remove tests * GH-728: introduce trait for ConfigurationChangesubs * GH-728: refactor out the subs for UpdateWallets and UpdatePassword * GH-728: some renames * GH-728: add TODO and minor reordering * GH-728: make the test the_password_is_synchronised_among_other_actors_when_modified stronger * GH-728: add formatting changes * GH-728: make enum usage more explicit * GH-728: remove clippy warnings * GH-728: do some renames * GH-728: fix wrong rename and import * GH-728: use peer actors for generating config change subs * GH-728: recreate ConfigChangeSubs * GH-728: remove config_change_subs.rs * GH-728: test for ConfigChangeMsg in Accountant contain assertions * GH-728: test for ConfigChangeMsg in Neighborhood contain assertions * GH-728: test for ConfigChangeMsg in BlockchainBridge contain assertions * GH-728: small rename * GH-728: add context_id to fn * GH-728: refactor the fn to transform associated functions to methods * GH-728: minor fixes * GH-728: add wallet_opt as a new argument in the begin_scan fn * GH-728: remove the use of field consuming_wallet_opt from BlockchainBridge * GH-728: remove the field consuming_wallet_opt from BlockchainBridge * GH-728: don't send the ConfigChangeMsg to the BlockchainBridge * GH-728: use the earning wallet in Receivable Scanner's begin_scan * GH-728: don't save a reference of earning wallet inside Scanners * GH-728: store the earning wallet directly without an Rc * GH-728: fix the failing test * GH-728: formatting changes * GH-728: remove the earning wallet from ReceivableScannerBuilder * GH-728: check wallet in the begin_scan() for ScannerMock * GH-728: remove unnecessary TODO * GH-728: formatting changes * GH-728: fix the failing test * GH-728: remove unused import in blockchain_interaction_test.rs * GH-728: BlockchainBridge receives consuming_wallet instead of an Option<T> * GH-728: Check consuming wallet before sending a msg to BlockchainBridge * GH-728: remove Option<T> from the wallet_opt param in begin_scan fn * GH-728: remove commented out code * GH-728: modify AccountantBuilder to make it's field names contain opt * GH-728: improve test mocks * GH-728: introduce another URL for mumbai testnet * GH-728: change the message in trace log * GH-728: test drive the NoConsumingWallet Error * GH-728: reordering * GH-728: add better logging * GH-728: Review 2 changes * GH-728: Review 2 leftover changes * GH-728: add better assertions for logger
…works for desired country_code exit node
…exit_location_opt
…, created test_dbip_country.rs
…esearch_neighborhood, recursion guts moved to outbound function
…code from db_countries, TODO created
* GH-800: Write the most basic TODOs for this card * GH-800: Add todos for renaming purposes * GH-800: Add a message scheduler for purging the stream key * GH-800: Improve the test handle_client_response_payload_purges_stream_keys_for_terminal_response * GH-800: Make delay configurable via constant * GH-800: introduce StreamSenders * GH-800: introduce channel for shutdown signal * GH-800: add test connection_shutdown_test.rs * GH-800: test drive the shutdown signal in StreamReader * GH-800: refactor test stream_reader_shuts_down_when_it_receives_the_shutdown_signal * GH-800: some refactor inside the file stream_reader * GH-800: some more refactoring * GH-800: trying_to_write_a_test_for_stream_senders was a success * GH-800: did some refactoring for trying_to_write_a_test_for_stream_senders * GH-800: stream_handler_pool_sends_shutdown_signal_when_last_data_is_true passes for the first time * GH-800: Minor refactor for the test stream_handler_pool_sends_shutdown_signal_when_last_data_is_true * GH-800: more refactoring of the test stream_handler_pool_sends_shutdown_signal_when_last_data_is_true * GH-800: stream_handler_pool_sends_shutdown_signal_when_last_data_is_true is working fine * GH-800: some more todos removed * GH-800: clean_up_dead_streams_logs_when_the_shutdown_channel_is_down is passing * GH-800: tests are passing in StreamHandlerPool * GH-800: Wrote a test for the case when the shutdown signal channel is gone * GH-800: make it easier to understand who experiences the write error * GH-800: trying to write test while_housekeeping_the_stream_senders_are_received_by_stream_handler_pool * GH-800: add test add_new_streams_works * GH-800: wip: add the log * GH-800: test proxy_client_stream_reader_dies_when_client_stream_is_killed_integration is passing * GH-800: change the channel from crossbeam to tokio * GH-800: Add fn send_shutdown_signal_to_stream_reader * GH-800: wip: fixing 2 tests * GH-800: stream_handler_pool_sends_shutdown_signal_when_last_data_is_true is passing * GH-800: all tests in stream_handler_pool.rs are passing * GH-800: add test for the logs; all tests passing * GH-800: remove lookup_ip() mock fns from a test * GH-800: remove warnings * GH-800: use fn send_shutdown_signal_to_stream_reader in clean_up_dead_streams() * Revert "GH-800: use fn send_shutdown_signal_to_stream_reader in clean_up_dead_streams()" This reverts commit ae08930. * Revert "GH-800: remove warnings" This reverts commit d81c2f0. * Revert "GH-800: remove lookup_ip() mock fns from a test" This reverts commit 1880006. * Revert "GH-800: add test for the logs; all tests passing" This reverts commit 4f8c141. * Revert "GH-800: all tests in stream_handler_pool.rs are passing" This reverts commit 31db7c4. * Revert "GH-800: stream_handler_pool_sends_shutdown_signal_when_last_data_is_true is passing" This reverts commit 54040ae. * Revert "GH-800: wip: fixing 2 tests" This reverts commit f94c8d3. * Revert "GH-800: Add fn send_shutdown_signal_to_stream_reader" This reverts commit 3b387a7. * Revert "GH-800: change the channel from crossbeam to tokio" This reverts commit 2ecfebc. * GH-800: reverted the channel to crossbeam; remove warnings * GH-800: solve some TODOs * GH-800: add refactored fn send_shutdown_signal_to_stream_reader; crtitical integration test passing * GH-800: write_failure_for_nonexistent_stream_generates_termination_message is improved * GH-800: everything is tested * GH-800: fix proxy_server_receives_terminal_response_from_hopper * GH-800: trigger actions * GH-800: assert on a different error on non-mac os * GH-80: add changes of self-review * GH-800: some other missed changes * GH-800: add review 1 changes * GH-800: add review 2 changes * GH-800: add review 3 changes * GH-800: add review 4 changes * GH-800: add better logging * GH-800: delay purge when the report_to_counterpart is false * GH-800: final changes * GH-800: review changes * GH-800: fix the final comment discussion changes * GH-800: fix multiple_stream_zero_hop_test
…into GH-788-QA-amoy
* adjust github context for correct upload directory name add echo source branch step Signed-off-by: KauriHero <[email protected]> * bump version for upload/download artifact Signed-off-by: KauriHero <[email protected]> --------- Signed-off-by: KauriHero <[email protected]>
…ation test of exit_location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.