-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a setting for opening the folder after extracting from archive #540
base: main
Are you sure you want to change the base?
Conversation
Could you also add the changes to NanaZip.UI.Classic? Thanks. Kenji Mouri |
Hey Kenji, This is now done. What should I do for string translation? |
https://github.com/M2Team/NanaZip/tree/main/NanaZipPackage/Strings Maybe it can help. Kenji Mouri |
IMO it'd be better as a per-extraction setting (in NanaZip.Windows) rather than a FM setting. |
You're free to make the change but this one will work with shell extensions too, since you doing get pop-up for some of em |
I've addded the Dutch one, the other languages I do not speak. Is this sufficient? |
I'm sorry I forgot to say I hope we can add the NanaZip modification mark when modifying the 7-Zip mainline source code for better mainline synchronization maintenance which can reduce the regression. Here is an example: NanaZip/NanaZip.Core/SevenZip/CPP/7zip/UI/Console/Main.cpp Lines 128 to 137 in 27f148f
Kenji Mouri |
It's OK for Nana series projects. English is the only mandatory language that needs support. (Because the existence of English language resources can help the community translate into other languages.) Kenji Mouri |
The .rc and .h files should also add the modification mark. Kenji Mouri |
Greetings fellow earthlings,
I have added a setting for opening the folder after extraction.
I've never done c++ development before so any feedback is welcome if something is out of order.
Can this be marked as draft for now?
Is machine translated fine or is there a specific community process?