Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a setting for opening the folder after extracting from archive #540

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DaxDupont
Copy link

@DaxDupont DaxDupont commented Jan 5, 2025

Greetings fellow earthlings,

I have added a setting for opening the folder after extraction.
I've never done c++ development before so any feedback is welcome if something is out of order.
Can this be marked as draft for now?

Is machine translated fine or is there a specific community process?

@MouriNaruto
Copy link
Member

Could you also add the changes to NanaZip.UI.Classic? Thanks.

Kenji Mouri

@DaxDupont
Copy link
Author

Could you also add the changes to NanaZip.UI.Classic? Thanks.

Kenji Mouri

Hey Kenji, This is now done.

What should I do for string translation?

@MouriNaruto
Copy link
Member

https://github.com/M2Team/NanaZip/tree/main/NanaZipPackage/Strings

Maybe it can help.

Kenji Mouri

@dinhngtu
Copy link
Contributor

dinhngtu commented Jan 6, 2025

IMO it'd be better as a per-extraction setting (in NanaZip.Windows) rather than a FM setting.

@DaxDupont
Copy link
Author

IMO it'd be better as a per-extraction setting (in NanaZip.Windows) rather than a FM setting.

You're free to make the change but this one will work with shell extensions too, since you doing get pop-up for some of em

@DaxDupont
Copy link
Author

https://github.com/M2Team/NanaZip/tree/main/NanaZipPackage/Strings

Maybe it can help.

Kenji Mouri

I've addded the Dutch one, the other languages I do not speak. Is this sufficient?

@MouriNaruto
Copy link
Member

I'm sorry I forgot to say I hope we can add the NanaZip modification mark when modifying the 7-Zip mainline source code for better mainline synchronization maintenance which can reduce the regression. Here is an example:

// **************** NanaZip Modification Start ****************
//static const char * const kCopyrightString = "\n7-Zip"
// PROG_POSTFIX_2
// " " MY_VERSION_CPU
// " : " MY_COPYRIGHT_DATE "\n";
static const char * const kCopyrightString = "\nNanaZip"
PROG_POSTFIX_2
" " MILE_PROJECT_VERSION_UTF8_STRING " (" MY_CPU_NAME ")"
" : " "(c) M2-Team and Contributors. All rights reserved." "\n";
// **************** NanaZip Modification End ****************

Kenji Mouri

@MouriNaruto
Copy link
Member

https://github.com/M2Team/NanaZip/tree/main/NanaZipPackage/Strings
Maybe it can help.
Kenji Mouri

I've addded the Dutch one, the other languages I do not speak. Is this sufficient?

It's OK for Nana series projects. English is the only mandatory language that needs support. (Because the existence of English language resources can help the community translate into other languages.)

Kenji Mouri

@MouriNaruto
Copy link
Member

The .rc and .h files should also add the modification mark.

Kenji Mouri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants