Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 32bit - Zip-stream with version 2.1 instead of 3.1 #2934

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 19, 2025

Fixes #2933

@ildyria ildyria requested a review from a team as a code owner January 19, 2025 20:17
@ildyria ildyria marked this pull request as draft January 19, 2025 20:19
@ildyria
Copy link
Member Author

ildyria commented Jan 19, 2025

@RustyPotato could you try this branch ?

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 44.64286% with 31 lines in your changes missing coverage. Please review.

Project coverage is 90.48%. Comparing base (cdc3850) to head (c87a92d).

Additional details and impacted files

@ildyria
Copy link
Member Author

ildyria commented Jan 19, 2025

@RustyPotato you may need to remove the composer.lock before doing your install, but in theory it should now support your 32 bit install.

@tinohager
Copy link
Contributor

Couldn't the zip creation also be outsourced to the client?
https://github.com/gildas-lormeau/zip.js

the latest 2 version would be 2.4.0
https://github.com/maennchen/ZipStream-PHP/releases/tag/2.4.0

@ildyria
Copy link
Member Author

ildyria commented Jan 20, 2025

Couldn't the zip creation also be outsourced to the client? gildas-lormeau/zip.js

The problem is that the response is in streaming mode, In version 3 of Lychee, we were creating the zip file serverside before sending it. This has changed by the use of ZipStream, but I am not knowledgeable enough of how streaming files works with http, not how it would be possible for the client to know, that is one file, that is the next file.
The advantage of streaming the zip file directly is that the client no longer need to keep the page open and can just have it run in a background tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

32 bit no longer supported
2 participants