feat(entities-plugin): add streaming custom plugin support #1896
+166
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekolab
force-pushed
the
feat/plugin-select-streaming
branch
4 times, most recently
from
cfd823b to
316c7e4
Compare
Justineo
reviewed
Jan 20, 2025
|
|
||
| - type: `boolean` | ||
| - type: `false | 'disabled' | 'schema' | 'streaming'` |
There was a problem hiding this comment.
Do you think it will be better to use 'hidden' or 'none' instead of keeping the boolean type here?
nekolab
force-pushed
the
feat/plugin-select-streaming
branch
3 times, most recently
from
cb7d3e8 to
27c8d62
Compare
Changes include: 1. Remove `disableCustomPlugins` 2. A new prop `customPluginSupport` is added to indicate the which type of custom plugin should be created for the CP 3. The plugin grid now renders schema-only and streaming custom plugins correctly. 4. `getCustomEditRoute` now provides `type: 'schema' | 'streaming'` for custom plugin type indication 5. Text and sandbox change JIRA: KM-895 Remove disableCustomPlugins and use customPlugins instead The customPlugins indicates custom plugin support and which type of custom plugins should be created for the control plane getCustomEditRoute now provides type: 'streaming' | 'non-streaming' for custom plugin type indication Text and sandbox change JIRA: KM-895
nekolab
force-pushed
the
feat/plugin-select-streaming
branch
from
27c8d62 to
30996c1
Compare
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
disableCustomPluginscustomPluginSupportis added to indicate the which type of custom plugin should be created for the CPgetCustomEditRoutenow providestype: 'schema' | 'streaming'for custom plugin type indicationJIRA: KM-895