fix(runloop): skip router rebuilding if reconfigure is running #14056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
cherry-pick kong-ee
ADD-SP
force-pushed
the
add_sp/refactor-rebuild-timers
branch
2 times, most recently
from
0a5cdf2 to
5b70a5d
Compare
ADD-SP
force-pushed
the
add_sp/refactor-rebuild-timers
branch
from
5b70a5d to
fcb7a5f
Compare
ADD-SP
force-pushed
the
add_sp/refactor-rebuild-timers
branch
from
fcb7a5f to
9655d1c
Compare
Oyami-Srk
approved these changes
Jan 9, 2025
chobits
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In rare cases, the rebuild timer will interrupt the reconfigure handler because of
router was changed while rebuilding it, which results in an outdated plugin iterator and balancer.It is hard to test this rare race condition.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-6015