Update CI julia versions #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Oct 30, 2023
.github/workflows/ci.yml
Outdated
Comment on lines
26
to
32
| - '1.6' | ||
| # - '1.7' | ||
| # - '1.8' | ||
| # - '1.9' | ||
| - '1' | ||
| - '~1.10.0-0' | ||
| # - 'nightly' |
There was a problem hiding this comment.
IMO we should test the stable Julia version (1.9 currently, 1 in CI), the latest LTS (1.6), and the oldest supported version ('1.0') to avoid accidentally breaking anything.
We could add nightly but I assume it would be quite noisy - nightly tends to break things quite often (in particular when relying on internals such as LinearAlgebra here) but most of these broken nightlies won't result in a broken stable release in my experience.
|
Yes, I want to reproduce it and also keep it open until the problem get fixed. So we can rerun the CI. |
|
I checked it locally and CI is failing on Julia 1.10 |
|
this line: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reveals the problem in #242