Skip to content

Commit

Permalink
support 0.7 still
Browse files Browse the repository at this point in the history
  • Loading branch information
@oxinabox
oxinabox authored Dec 28, 2019
1 parent 9674e17 commit 0d932d4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
SHA = "ea8e919c-243c-51af-8825-aaa63cd721ce"

[compat]
julia = "1"
julia = "0.7, 1"

[extras]
BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf"
Expand Down

5 comments on commit 0d932d4

@oxinabox
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/7254

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:

git tag -a v0.2.1 -m "<description of version>" 0d932d415be2591c71db35e998d3e0088cf464d4
git push origin v0.2.1

@jw3126
Copy link
Collaborator

@jw3126 jw3126 commented on 0d932d4 Dec 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also run CI on 0.7?

@oxinabox
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂ Not worth it IMO.
Noone actually uses 0.7.
And this code doesn't use the 1 feature that changed between 1.0 and 0.7 so I think we're good.
Just making this change to get the registration can go through.
as dropping 0.7 support requires tagging a breaking change

@jw3126
Copy link
Collaborator

@jw3126 jw3126 commented on 0d932d4 Dec 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

Please sign in to comment.