Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable initialize_code_coverage if code coverage is enabled #55

Merged

Conversation

Levi-Armstrong
Copy link
Collaborator

This is to address issue #54. @gavanderhoorn I believe this should solve the issue; do you agree? I have update ros_industrial_cmake_boilerplate to support disabling/enabling this and created a release.

@Levi-Armstrong Levi-Armstrong merged commit 5b0cff4 into Jmeyer1292:master Apr 10, 2021
@Levi-Armstrong Levi-Armstrong deleted the issue/InitializeCodeCoverage branch April 10, 2021 02:52
@gavanderhoorn
Copy link
Collaborator

I haven't checked how ros_industrial_cmake_boilerplate works exactly.

What's important I believe is to make sure nothing listed as a test_depend is either find_package(..)d or find_program(..)d outside ENABLE_TESTING conditional blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants