Pin httpx dependency so spleeter follows redirects for model downloading #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
spleeter
model downloads are failing, at least for me, because:spleeter
models when downloaded from github go through a redirection.spleeter-web
specifies ahttpx
dependency of 0.26.0.httpx
no longer follows redirects by default.spleeter
fails to explicitly request following redirects.This issue has been called out in an unmerged
spleeter
PR: deezer/spleeter#808 but that has not been merged for a long time.One possible solution might be to downgrade thehttpx
dependency to < 0.20.0, but I don't know what other repercussions this could have. The other solution, which I've chosen here, is to fix thespleeter
code with a patch applied at container build time.After discussion of alternatives with @JeffreyCA, this PR pins
httpx
at 0.19.0