Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mass addition of bib information (Closes #372) #12025
base: main
Are you sure you want to change the base?
Implement mass addition of bib information (Closes #372) #12025
Changes from 29 commits
887dd35
656facf
0409856
489b512
dc138ce
0532df4
012dd9a
f8267ac
74f2473
29759a6
37cfeae
77e0d51
e6f0ad2
c5b7b4c
5b829b1
350502e
fe46c0c
8eac6a9
5d54083
93072cf
262d25d
4667124
ae4df14
5ed3d70
74a6285
8d9bdce
95e9ae8
9fdbbb4
ce1ea3e
7305f3c
9dce81a
5f24815
d17fd88
61f5a8f
86051ac
198f2d0
ace1975
74681e1
3197ef4
c04a2fa
d2566db
4d1b88d
e8645a2
ac8c59d
5172bc2
05b3c42
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, what I written in the last review, but I think, it was about consistency?
Haven't I written
MULTI_
be used as prefix?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
runLater()
needed? The whole thing runs in a background task - and there is no interaction with the UI, is it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static
method are a strong indicator for a bad design.Please, simply create a new class inherting from
BackgroundTask
. Seeorg.jabref.gui.externalfiles.UnlinkedFilesCrawler
for an example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No empty line before "package"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No empty line before package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no test for this. Please add a JUNit test (ctrl+shift+t in IntelliJ gets you started). -- Reading a unit test makes it easier to check whether the logic s correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No empty line at the beginning of a file (not sure why this file was touched by you)