Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arange default values #20

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Add arange default values #20

merged 4 commits into from
Nov 18, 2024

Conversation

tkarna
Copy link
Collaborator

@tkarna tkarna commented Nov 11, 2024

  • arange now supports Array API default values
    • sp.arange(0, 4, 1) -> [0, 1, 2, 3] as before
    • sp.arange(0, 4) -> [0, 1, 2, 3]
    • sp.arange(4) -> [0, 1, 2, 3]
    • sp.arange(4, 0) -> []
    • sp.arange(0, 4, -1) -> []
  • Also removes unnecessary all_axes reduction argument in wave and shallow water benchmarks

@tkarna tkarna requested review from fschlimb and AllanZyne November 11, 2024 07:40
@tkarna tkarna force-pushed the arange-convenience branch from 0952df3 to 596d829 Compare November 11, 2024 07:55
Copy link
Contributor

@fschlimb fschlimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tkarna tkarna merged commit 6b74a68 into main Nov 18, 2024
2 checks passed
@tkarna tkarna deleted the arange-convenience branch November 18, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants