Implement permute_dims #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AllanZyne
commented
Aug 4, 2024
•
AllanZyne
commented
- very low efficient implementation in distributed mode (algorithm need to improve in the future)
- fix some build warnings
- support building & running sharpy using imex build directory directly (without deploy, occupy too many disk space)
AllanZyne
force-pushed
the
review/yang/permute_dims
branch
from
75aed16 to
77f5ba0
Compare
AllanZyne
force-pushed
the
review/yang/permute_dims
branch
from
77f5ba0 to
e4895f0
Compare
fschlimb
reviewed
Sep 9, 2024
fschlimb
reviewed
Sep 9, 2024
fschlimb
requested changes
Sep 9, 2024
|
Very nice! |
|
Hi @tkarna, I have updated the transpose.py, please check |
tkarna
requested changes
Oct 23, 2024
fschlimb
reviewed
Oct 28, 2024
examples/transpose.py
Outdated
|
|
||
| def sp_transpose(arr): | ||
| brr = sharpy.permute_dims(arr, [1, 0]) | ||
| sharpy.sync() |
There was a problem hiding this comment.
Why do we need a sync here?
tkarna
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.