Cleanup code #34
Merged
Cleanup code #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved test_get_version and test_get_version_string to the end of the test file with comment for why. Expanded return statuses from cbwr_set which we do not consider test failure, with comment added.
ekomarova
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated copyright year range to include 2024.
Moved tests to get library version to the end of test file to allow
cbwr_setto be tested.cbwr_setno longer considers status 'err_mode_change_failure' (return status -8) a reason for test failure. This status can be returned if library's CBWR state has been already initialized and locked, and an attempt was made to reset it. Functionmkl_get_versionsets and locks CBWR state, for example.In Cython code, added
noexceptqualifiers where exception is not expected.