Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dpcpp runtime to project dependencies section of wheel metadata #1914

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Closes gh-1910.

This PR modifies "pyproject.toml" to add DPC++ runtime libraries to project.dependencies.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Dec 2, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.668%. remained the same
when pulling b4c4dcc on add-dpcpp-runtime-to-project-dependencies-section-of-wheel-metadata
into 4a94ef9 on master.

Copy link

github-actions bot commented Dec 2, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310ha798474_283 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working now, dependencies install when built wheel is installed with pip, LGTM

@oleksandr-pavlyk
Copy link
Collaborator Author

I actually think we should not adopt this change.

The dependencies list must specify Python only dependencies, assuming required libraries are provided by user's OS.

We rather should rely of project.optional-dependencies section to define optional dependencies, for example

[project.optional-dependencies]
coverage = [<SKIPPED>]
docs = [<SKIPPED>]
dpcpp_rt = ["intel-cmplr-lib-rt", "intel-sycl-rt"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required run dependency intel-sycl-rt is missing upon install of dpctl wheel package
3 participants