(Host|Service) Detail view: Introduce parents and children tab #1098

sukhwinder33445 · 2024-11-25T14:19:04Z

TODO

Once ObjectSuggestions: Make CustomVar suggestion sources adjustable #1100 is merged, add the following method:
->onlyWithCustomVarSources(['host', 'service', 'hostgroup', 'servicegroup'])
to the chain in CompleteAction() of Host/ServiceController to fix search suggestions in parents & children tab.
Adjust redundancy-group-list-item.less once item-list.less: Always apply calculated   margin to .title content ipl-web#240 is merged.

nilmerg

From the issue:

The tabs are only visible if the object is linked in the database table dependency_node.

The tabs are always visible right now.

raviks789 · 2024-12-16T11:18:45Z

Except for the error in the search bar while trying to apply filter in Parents/Children tabs, everything else seems to work as listed out in the issue.

application/controllers/HostController.php

application/controllers/ServiceController.php

application/controllers/HostController.php

public/css/list/redundancy-group-list-item.less

raviks789 · 2025-01-10T09:03:44Z

application/controllers/ServiceController.php

+
+        $limitControl = $this->createLimitControl();
+        $paginationControl = $this->createPaginationControl($nodesQuery);
+        $sortControl = $this->createSortControl(


IMO, it would be nice to have a default sort here. Or you could add getDefaultSort method to DependencyNode model. In which case you do not have to change the code every where createSortControl method is called.

I'm inclined to agree, why is this resolved without change and comment?

We discussed this offline and i added the $defaultSort afterward.
This cannot be added as DependencyNode::getDefaultSort(), as the columns are only aliases and do not work.

nilmerg

I still need to review HostController::joinFix, can't wrap my head around it right now…

application/controllers/ServiceController.php

nilmerg · 2025-01-16T15:21:17Z

application/controllers/ServiceController.php

+
+        $limitControl = $this->createLimitControl();
+        $paginationControl = $this->createPaginationControl($nodesQuery);
+        $sortControl = $this->createSortControl(


I'm inclined to agree, why is this resolved without change and comment?

application/controllers/HostController.php

nilmerg · 2025-01-20T10:34:49Z

application/controllers/ServiceController.php

+                    ->setParams($requestParams)
+            )->setSuggestionUrl(
+                Url::fromPath('icingadb/service/children-complete')
+                    ->setParams($requestParams)


it's the same here, clone the params please

nilmerg · 2025-01-20T10:38:12Z

application/controllers/HostController.php

+                    ->setParams($requestParams)
+            )->setSuggestionUrl(
+                Url::fromPath('icingadb/host/children-complete')
+                    ->setParams($requestParams)


you know the deal :)

nilmerg · 2025-01-20T10:40:59Z

public/css/list/redundancy-group-list-item.less

+.item-list.detailed { //TODO: ipl-web item-list applies these changes for .default-layout class, which is removed for detailed view, because detail view can show long display names on multiple lines.
+  .redundancy-group-list-item { // but this margin rules are actually general and can be applied to all list items, so we should add them separately (without .default-layout class) in item-list.less instead to generalize them.
+    .title > * {
+      margin: 0 .28125em; // 0 calculated &nbsp; width
+
+      &:first-child {
+        margin-left: 0;
+      }
+
+      &:last-child {
+        margin-right: 0;
+      }
+    }
+  }
+}
+// remove code above once https://github.com/Icinga/ipl-web/pull/240 is merged.


please clean this up, the linked pr is closed and the label seems still being wrapped in a span

- Otherwise the searchbar uses it as base filter and apply it on the query

- Set the outer tab as active. Previously, the inner tab was activated in the setTitleTab method, but the outer tab does not know about the state of inner tabs. So whenever sendMultipartUpdate() -> getActiveTab() was called, the retured value was always null.

…port it

…o `severity`

…n` for `parent & children tab`

…th context This msg should be handled same as the host <is/on> word, no element wrapping. This way, the margin arround the msg is applied properly.

sukhwinder33445 self-assigned this Nov 25, 2024

sukhwinder33445 changed the base branch from main to dependencies November 25, 2024 14:19

sukhwinder33445 requested a review from nilmerg November 26, 2024 07:52

sukhwinder33445 force-pushed the introduce-parents-children-tab branch from 59dc8c9 to 74bb945 Compare December 5, 2024 10:16

cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Dec 5, 2024

nilmerg linked an issue Dec 9, 2024 that may be closed by this pull request

List views for parents and children #1063

Open

nilmerg requested changes Dec 9, 2024

View reviewed changes

sukhwinder33445 force-pushed the introduce-parents-children-tab branch 2 times, most recently from c37ece0 to 9ab8072 Compare December 16, 2024 09:21

raviks789 reviewed Dec 17, 2024

View reviewed changes

sukhwinder33445 force-pushed the introduce-parents-children-tab branch 2 times, most recently from fb557c7 to 03a160d Compare December 18, 2024 16:35

sukhwinder33445 force-pushed the introduce-parents-children-tab branch from 03a160d to 2caf0ae Compare January 9, 2025 10:22

raviks789 reviewed Jan 10, 2025

View reviewed changes

nilmerg requested a review from raviks789 January 15, 2025 14:10

sukhwinder33445 force-pushed the introduce-parents-children-tab branch 3 times, most recently from df52697 to 25d1b6b Compare January 16, 2025 10:40

raviks789 approved these changes Jan 16, 2025

View reviewed changes

nilmerg requested changes Jan 16, 2025

View reviewed changes

sukhwinder33445 requested a review from nilmerg January 17, 2025 11:16

sukhwinder33445 force-pushed the introduce-parents-children-tab branch 2 times, most recently from 013432d to 0564431 Compare January 17, 2025 11:33

nilmerg requested changes Jan 20, 2025

View reviewed changes

sukhwinder33445 added 5 commits January 20, 2025 14:32

(Host|Service)Controller: Let the init() render the object header

82a6590

(Host|Service)Controller: Add parents and children tab

3124eaf

(Host|Service)Controller: Shift the required param

9f29453

- Otherwise the searchbar uses it as base filter and apply it on the query

(Host|Service)Controller: Add return type to methods

e92e58f

sukhwinder33445 added 7 commits January 20, 2025 14:37

Add view mode functionality for RedundancyGroup items

dcbff76

Add csv/json export support for parents and children tab

8580df3

Don't show parents children tab if icingadb.schema does not sup…

509df4c

…port it

(Host|Service)Controller: Use Translation trait method

2f17517

(Host|Service)Controller: Sort parents children tab list by default t…

6b868a2

…o `severity`

(Host/Service)Controller: Change method name and fix syntax

6d52ef6

(Host/Service)Controller: Add separated `(searchEditor/complete)Actio…

aa33908

…n` for `parent & children tab`

sukhwinder33445 force-pushed the introduce-parents-children-tab branch from 0564431 to aa33908 Compare January 20, 2025 13:43

sukhwinder33445 mentioned this pull request Jan 20, 2025

RedundancyGroup: Don't wrap state msg into span #1130

Closed

RedundancyGroup: Don't wrap state msg into span and translate it wi…

7068ddc

…th context This msg should be handled same as the host <is/on> word, no element wrapping. This way, the margin arround the msg is applied properly.

sukhwinder33445 mentioned this pull request Jan 20, 2025

item-list.less: Don't unset margin-right for :only-child Icinga/ipl-web#245

Open

(Host/Service)Controller: Add missing onlyWithCustomVarSources() call

49278c6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(Host|Service) Detail view: Introduce parents and children tab #1098

(Host|Service) Detail view: Introduce parents and children tab #1098

sukhwinder33445 commented Nov 25, 2024 •

edited

Loading

nilmerg left a comment

raviks789 commented Dec 16, 2024

raviks789 Jan 10, 2025

nilmerg Jan 16, 2025

sukhwinder33445 Jan 16, 2025 •

edited

Loading

nilmerg left a comment

nilmerg Jan 16, 2025

nilmerg Jan 20, 2025

nilmerg Jan 20, 2025

nilmerg Jan 20, 2025

(Host|Service) Detail view: Introduce parents and children tab #1098

Are you sure you want to change the base?

(Host|Service) Detail view: Introduce parents and children tab #1098

Conversation

sukhwinder33445 commented Nov 25, 2024 • edited Loading

TODO

nilmerg left a comment

Choose a reason for hiding this comment

raviks789 commented Dec 16, 2024

raviks789 Jan 10, 2025

Choose a reason for hiding this comment

nilmerg Jan 16, 2025

Choose a reason for hiding this comment

sukhwinder33445 Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

nilmerg left a comment

Choose a reason for hiding this comment

nilmerg Jan 16, 2025

Choose a reason for hiding this comment

nilmerg Jan 20, 2025

Choose a reason for hiding this comment

nilmerg Jan 20, 2025

Choose a reason for hiding this comment

nilmerg Jan 20, 2025

Choose a reason for hiding this comment

sukhwinder33445 commented Nov 25, 2024 •

edited

Loading

sukhwinder33445 Jan 16, 2025 •

edited

Loading