Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild project artifacts #93

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Rebuild project artifacts #93

merged 1 commit into from
Nov 15, 2024

Conversation

caufieldjh
Copy link
Collaborator

No description provided.

@caufieldjh caufieldjh requested a review from cmungall November 15, 2024 20:16
@caufieldjh
Copy link
Collaborator Author

The relevant file is https://github.com/INCATools/kgcl/blob/f49dd3e56280eef8a40eafc629e1080819501dc2/project/owl/kgcl.owl.ttl - see, for example, MultiNodeObsoletion.

Before:

kgcl:MultiNodeObsoletion a owl:Class ;
    rdfs:label "MultiNodeObsoletion" ;
    rdfs:seeAlso <https://github.com/cmungall/obo-scripts/blob/master/obo-obsoletify.pl> ;
    rdfs:subClassOf [ a owl:Restriction ;
            owl:allValuesFrom kgcl:NodeObsoletion ;
            owl:onProperty kgcl:change_set ],
        [ a owl:Restriction ;
            owl:minCardinality 0 ;
            owl:onProperty kgcl:associated_change_set ],
        [ a owl:Restriction ;
            owl:maxCardinality 1 ;
            owl:onProperty kgcl:change_description ],
        [ a owl:Restriction ;
            owl:allValuesFrom xsd:string ;
            owl:onProperty kgcl:change_description ],
        [ a owl:Restriction ;
            owl:minCardinality 0 ;
            owl:onProperty kgcl:change_set ],
        [ a owl:Restriction ;
            owl:minCardinality 0 ;
            owl:onProperty kgcl:change_description ],
        [ a owl:Restriction ;
            owl:maxCardinality 1 ;
            owl:onProperty kgcl:associated_change_set ],
        [ a owl:Restriction ;
            owl:allValuesFrom xsd:string ;
            owl:onProperty kgcl:associated_change_set ],
        kgcl:ComplexChange ;
    skos:altLabel "multi class obsoletion",
        "multi concept obsoletion",
        "multi node deprecation",
        "multi term obsoletion" ;
    skos:definition "A complex change consisting of multiple obsoletions." ;
    skos:inScheme <https://w3id.org/kgcl> .

After (this PR):

kgcl:MultiNodeObsoletion a owl:Class ;
    rdfs:label "MultiNodeObsoletion" ;
    rdfs:seeAlso <https://github.com/cmungall/obo-scripts/blob/master/obo-obsoletify.pl> ;
    rdfs:subClassOf [ a owl:Restriction ;
            owl:allValuesFrom owl:Thing ;
            owl:onProperty kgcl:associated_change_set ],
        [ a owl:Restriction ;
            owl:maxCardinality 1 ;
            owl:onProperty kgcl:change_description ],
        [ a owl:Restriction ;
            owl:minCardinality 0 ;
            owl:onProperty kgcl:associated_change_set ],
        [ a owl:Restriction ;
            owl:allValuesFrom kgcl:NodeObsoletion ;
            owl:onProperty kgcl:change_set ],
        [ a owl:Restriction ;
            owl:minCardinality 0 ;
            owl:onProperty kgcl:change_description ],
        [ a owl:Restriction ;
            owl:minCardinality 0 ;
            owl:onProperty kgcl:change_set ],
        [ a owl:Restriction ;
            owl:maxCardinality 1 ;
            owl:onProperty kgcl:associated_change_set ],
        [ a owl:Restriction ;
            owl:allValuesFrom xsd:string ;
            owl:onProperty kgcl:change_description ],
        kgcl:ComplexChange ;
    skos:altLabel "multi class obsoletion",
        "multi concept obsoletion",
        "multi node deprecation",
        "multi term obsoletion" ;
    skos:definition "A complex change consisting of multiple obsoletions." ;
    skos:inScheme <https://w3id.org/kgcl> .

a major difference being introduction of

    rdfs:subClassOf [ a owl:Restriction ;
            owl:allValuesFrom owl:Thing ;
            owl:onProperty kgcl:associated_change_set ],

@cmungall
Copy link
Contributor

robot convert -I https://raw.githubusercontent.com/INCATools/kgcl/f49dd3e56280eef8a40eafc629e1080819501dc2/project/owl/kgcl.owl.ttl -o /tmp/foo.owl && grep Error foo.owl

empty. Hurrah!

yes that is a convoluted way to test. Because. OWL.

For good measure, looks as expected in Protege:

image

@cmungall cmungall merged commit 1c7de1a into main Nov 15, 2024
6 checks passed
@caufieldjh caufieldjh deleted the rebuild4 branch November 15, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants