Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of undefined slots in slot usage (#88) #89

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Fix use of undefined slots in slot usage (#88) #89

merged 6 commits into from
Nov 14, 2024

Conversation

cmungall
Copy link
Contributor

Fixes #88

@cmungall cmungall requested a review from caufieldjh November 14, 2024 02:32
@@ -625,7 +627,7 @@ classes:
slot_usage:
change_description:
string_serialization: obsoleting {about_node}
associated change set:
associated_change_set:
is_a: change_set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to say is_a: change_set here when it's already part of the slot definition below?

@caufieldjh
Copy link
Collaborator

Looking at this again, I think associated_change_set needs to be under the Change class instead of ComplexChange or classes like NodeChange won't inherit it

@caufieldjh caufieldjh merged commit a6b4779 into main Nov 14, 2024
6 checks passed
@caufieldjh caufieldjh deleted the issue-88 branch November 14, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some slot_usage fields refer to undefined slots
2 participants