Implement autoCodeGen vite plugin option #1385

ewen-lbh · 2024-11-09T17:34:31Z

To help everyone out, please make sure your PR does the following:

Update the first line to point to the ticket that this PR fixes
Add a message that clearly describes the fix
If applicable, add a test that would fail without this fix
Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
Includes a changeset if your fix affects the user with pnpm changeset

changeset-bot · 2024-11-09T17:34:35Z

🦋 Changeset detected

Latest commit: 6625779

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
houdini	Minor
houdini-adapter-auto	Patch
houdini-adapter-cloudflare	Patch
houdini-adapter-node	Patch
houdini-adapter-static	Patch
houdini-react	Patch
houdini-svelte	Patch
houdini-plugin-svelte-global-stores	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify · 2024-11-09T17:34:46Z

✅ Deploy Preview for houdini-docs-next canceled.

Name	Link
🔨 Latest commit	`6625779`
🔍 Latest deploy log	https://app.netlify.com/sites/houdini-docs-next/deploys/67321ef72e2a8a00082039a8

netlify · 2024-11-09T17:34:46Z

✅ Deploy Preview for houdinigraphql canceled.

Name	Link
🔨 Latest commit	`6625779`
🔍 Latest deploy log	https://app.netlify.com/sites/houdinigraphql/deploys/67321ef70c00890008e4335a

ewen-lbh · 2024-11-09T18:08:33Z

Okay, autoCodeGen: "smart" works!

The first change in a file site the dev server was started still triggers a reload because we don't know the documents yet, but as the devserver stays up, subsequent changes to the same file only trigger a full-page reload when a graphql document changes!

ewen-lbh · 2024-11-09T18:13:24Z

I removed my console.logs, but it looks like this:

# the quiet option for watchAndRun seems to be removed from kitql-watch-and-run...
 Watch-and-Run  ✔ Watch change 100ms
# changeing code in a svelte file
codegen? /home/uwun/projects.local/churros/packages/app/src/routes/(app)/events/[id]/edit/managers/+page.svelte
{
  absolutePath: '/home/uwun/projects.local/churros/packages/app/src/routes/(app)/events/[id]/edit/managers/+page.svelte',
  documents: {
    PageEventEditManager_ManagerUpdates: 'subscription PageEventEditManager_ManagerUpdates($event: LocalID!) {\n' +
      '      event(id: $event) {\n' +
      '        managers {\n' +
      '          user {\n' +
      '            uid\n' +
      '          }\n' +
      '          usedInvite {\n' +
      '            usesLeft\n' +
      '            unusable\n' +
      '          }\n' +
      '          ...PageEventEditManagers_ItemManager\n' +
      '        }\n' +
      '      }\n' +
      '    }',
    AddEventManager: 'mutation AddEventManager($user: UID!, $event: LocalID!, $power: EventManagerPowerLevel!) {\n' +
      '      upsertEventManager(user: $user, event: $event, powerlevel: $power) {\n' +
      '        ... on MutationUpsertEventManagerSuccess {\n' +
      '          data {\n' +
      '            id\n' +
      '            ...List_EventManagers_insert\n' +
      '          }\n' +
      '        }\n' +
      '        ...MutationErrors\n' +
      '      }\n' +
      '    }',
    CreateEventManagerInvite: 'mutation CreateEventManagerInvite(\n' +
      '      $event: LocalID!\n' +
      '      $power: EventManagerPowerLevel!\n' +
      '      $capacity: Capacity!\n' +
      '      $expiresAt: DateTime\n' +
      '    ) {\n' +
      '      upsertEventManagerInvite(\n' +
      '        event: $event\n' +
      '        input: { capacity: $capacity, expiresAt: $expiresAt, powerlevel: $power }\n' +
      '      ) {\n' +
      '        ... on MutationUpsertEventManagerInviteSuccess {\n' +
      '          data {\n' +
      '            id\n' +
      '            ...List_EventManagerInvites_insert @prepend\n' +
      '          }\n' +
      '        }\n' +
      '        ...MutationErrors\n' +
      '      }\n' +
      '    }'
  }
}
Skipped codegen for /home/uwun/projects.local/churros/packages/app/src/routes/(app)/events/[id]/edit/managers/+page.svelte since graphql documents did not change
# changeing a mutation store definition in that same file
 Watch-and-Run  ✔ Watch change 100ms
codegen? /home/uwun/projects.local/churros/packages/app/src/routes/(app)/events/[id]/edit/managers/+page.svelte
{
  absolutePath: '/home/uwun/projects.local/churros/packages/app/src/routes/(app)/events/[id]/edit/managers/+page.svelte',
  documents: {
    PageEventEditManager_ManagerUpdates: 'subscription PageEventEditManager_ManagerUpdates($event: LocalID!) {\n' +
      '      event(id: $event) {\n' +
      '        managers {\n' +
      '          user {\n' +
      '            uid\n' +
      '          }\n' +
      '          usedInvite {\n' +
      '            usesLeft\n' +
      '            unusable\n' +
      '          }\n' +
      '          ...PageEventEditManagers_ItemManager\n' +
      '        }\n' +
      '      }\n' +
      '    }',
    AddEventManager: 'mutation AddEventManager($user: UID!, $event: LocalID!, $power: EventManagerPowerLevel!) {\n' +
      '      upsertEventManager(user: $user, event: $event, powerlevel: $power) {\n' +
      '        ... on MutationUpsertEventManagerSuccess {\n' +
      '          data {\n' +
      '            id\n' +
      '            localID\n' +
      '            ...List_EventManagers_insert\n' +
      '          }\n' +
      '        }\n' +
      '        ...MutationErrors\n' +
      '      }\n' +
      '    }',
    CreateEventManagerInvite: 'mutation CreateEventManagerInvite(\n' +
      '      $event: LocalID!\n' +
      '      $power: EventManagerPowerLevel!\n' +
      '      $capacity: Capacity!\n' +
      '      $expiresAt: DateTime\n' +
      '    ) {\n' +
      '      upsertEventManagerInvite(\n' +
      '        event: $event\n' +
      '        input: { capacity: $capacity, expiresAt: $expiresAt, powerlevel: $power }\n' +
      '      ) {\n' +
      '        ... on MutationUpsertEventManagerInviteSuccess {\n' +
      '          data {\n' +
      '            id\n' +
      '            ...List_EventManagerInvites_insert @prepend\n' +
      '          }\n' +
      '        }\n' +
      '        ...MutationErrors\n' +
      '      }\n' +
      '    }'
  }
}
Regenerating runtime because /home/uwun/projects.local/churros/packages/app/src/routes/(app)/events/[id]/edit/managers/+page.svelte changed

see HoudiniGraphql/houdini#1385

AlecAivazis · 2024-11-13T01:00:01Z

packages/houdini/src/vite/documents.ts

+ * @param source the source code
+ * @returns an object mapping document names to their content
+ */
+export function extractDocuments(source: string): Record<string, string> {


This should rely on a shared function with the collectDocuments part of the codegen pipeline. Plugins can define their own logic for what it means to extract a document out of a file and we need to make sure we're picking them up.

the function is not currently exported -- exporting it is fine i guess?

also it goes thru every file, whereas i only need a single file, i'll add a variadic arg to specify source locations, tell me if you want it another way (such as breaking up collectDocuments into more functions)

AlecAivazis · 2024-11-13T01:00:54Z

packages/houdini/src/vite/index.ts

 	]
+
+	const codegen = async (_server: ViteDevServer | undefined, absolutePath: string | null) => {


Can you move this to its own file?

AlecAivazis · 2024-11-13T01:02:46Z

packages/houdini/src/vite/index.ts

+			} else if (fileContents) {
+				const previousDocuments = extractedDocuments[absolutePath]
+				if (!previousDocuments) {
+					// To prevent full-page reloads every time we change something in a new document, just don't reload.


I think this could be confusing - if the file changes, we should generate. Waiting til a second update will feel clunky if someone is putting a quick demo together where they are copying and pasting entire file contents

i was actually on the fence for this, but i think i aggree with you after all haha

AlecAivazis · 2024-11-26T05:32:09Z

@ewen-lbh any updates here? happy to revisit this when you're ready to see it through

ewen-lbh · 2024-11-26T17:24:15Z

hi! i'm hoping to get back to it this weekend, exams have been piling up cuz it's almost the end of the semester '^^

AlecAivazis · 2024-12-19T16:38:42Z

I'm going to close this for now. feel free to re-open this effort when you have time @ewen-lbh

ewen-lbh · 2024-12-21T16:17:44Z

hiii can you reopen the pr? i committed the changes and verified it works on a real life project ;)

Implement autoCodeGen vite plugin option

7d8e0b8

ewen-lbh added 2 commits November 9, 2024 18:46

Fix build errors

b85c365

Ignore eslint for while(true) in graphql strings extractor

d152a99

ewen-lbh force-pushed the autocodegen-options branch from 2e26c1e to d152a99 Compare November 9, 2024 17:49

Fix inverted condition & mishandling of documentless files

3b0bd70

Don't skip codegen on .gql files

d39fe2a

net7toulouse pushed a commit to inp-net/churros that referenced this pull request Nov 9, 2024

chore(houdini): enable houdini vite plugin smart autoCodeGen

418233e

see HoudiniGraphql/houdini#1385

net7toulouse pushed a commit to inp-net/churros that referenced this pull request Nov 10, 2024

chore(houdini): enable houdini vite plugin smart autoCodeGen

c661419

see HoudiniGraphql/houdini#1385

ewen-lbh force-pushed the autocodegen-options branch from 15cbc95 to 2dda139 Compare November 10, 2024 15:07

Smart autocodegen: skip codegen on newly discovered files

ebd937b

ewen-lbh force-pushed the autocodegen-options branch from 2dda139 to ebd937b Compare November 10, 2024 15:09

Handle .gql/.graphql files smartly

01786e8

ewen-lbh force-pushed the autocodegen-options branch from d518d3a to 01786e8 Compare November 10, 2024 23:25

net7toulouse pushed a commit to inp-net/churros that referenced this pull request Nov 10, 2024

chore(houdini): enable houdini vite plugin smart autoCodeGen

972d60d

see HoudiniGraphql/houdini#1385

net7toulouse pushed a commit to inp-net/churros that referenced this pull request Nov 11, 2024

chore(houdini): enable houdini vite plugin smart autoCodeGen

a463c66

see HoudiniGraphql/houdini#1385

Fix formatting

6200fee

ewen-lbh marked this pull request as ready for review November 11, 2024 15:11

Add a changeset

6625779

AlecAivazis requested changes Nov 13, 2024

View reviewed changes

AlecAivazis closed this Dec 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement autoCodeGen vite plugin option #1385

Implement autoCodeGen vite plugin option #1385

ewen-lbh commented Nov 9, 2024 •

edited

Loading

changeset-bot bot commented Nov 9, 2024 •

edited

Loading

netlify bot commented Nov 9, 2024 •

edited

Loading

netlify bot commented Nov 9, 2024 •

edited

Loading

ewen-lbh commented Nov 9, 2024

ewen-lbh commented Nov 9, 2024

AlecAivazis Nov 13, 2024

ewen-lbh Dec 21, 2024

ewen-lbh Dec 21, 2024

AlecAivazis Nov 13, 2024

AlecAivazis Nov 13, 2024

ewen-lbh Dec 21, 2024

AlecAivazis commented Nov 26, 2024

ewen-lbh commented Nov 26, 2024

AlecAivazis commented Dec 19, 2024

ewen-lbh commented Dec 21, 2024

		]

		const codegen = async (_server: ViteDevServer \| undefined, absolutePath: string \| null) => {

Implement autoCodeGen vite plugin option #1385

Implement autoCodeGen vite plugin option #1385

Conversation

ewen-lbh commented Nov 9, 2024 • edited Loading

To help everyone out, please make sure your PR does the following:

changeset-bot bot commented Nov 9, 2024 • edited Loading

🦋 Changeset detected

netlify bot commented Nov 9, 2024 • edited Loading

✅ Deploy Preview for houdini-docs-next canceled.

netlify bot commented Nov 9, 2024 • edited Loading

✅ Deploy Preview for houdinigraphql canceled.

ewen-lbh commented Nov 9, 2024

ewen-lbh commented Nov 9, 2024

AlecAivazis Nov 13, 2024

Choose a reason for hiding this comment

ewen-lbh Dec 21, 2024

Choose a reason for hiding this comment

ewen-lbh Dec 21, 2024

Choose a reason for hiding this comment

AlecAivazis Nov 13, 2024

Choose a reason for hiding this comment

AlecAivazis Nov 13, 2024

Choose a reason for hiding this comment

ewen-lbh Dec 21, 2024

Choose a reason for hiding this comment

AlecAivazis commented Nov 26, 2024

ewen-lbh commented Nov 26, 2024

AlecAivazis commented Dec 19, 2024

ewen-lbh commented Dec 21, 2024

ewen-lbh commented Nov 9, 2024 •

edited

Loading

changeset-bot bot commented Nov 9, 2024 •

edited

Loading

netlify bot commented Nov 9, 2024 •

edited

Loading

netlify bot commented Nov 9, 2024 •

edited

Loading