Enable Sorbet typechecking #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
MikeMcQuaid
approved these changes
Dec 24, 2024
- Sorbet complained about the original `Module.new(...)` syntax. - So I rewrote it to make a `module InfluxDBClient3` and then `include` it. - But then the actual formula-analytics command stopped working because it couldn't find the reference to `InfluxDBClient3.new`. - If we take a different approach here, is that any better?
SMillerDev
approved these changes
Dec 28, 2024
MikeMcQuaid
approved these changes
Dec 30, 2024
|
Yeah I have some more to do here now I'm back home from the third different Christmas family visit, will get to it soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typed: strictin all (non-package) files in Homebrew organisation brew#17297.brew tc homebrew/formula-analyticscome back green. And all the fixing the actual code because apparently Sorbet causes it all to break. 😅