groff: fix build #65042
Closed
groff: fix build #65042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
See #65000 (comment) Builds on #64842 - [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/HEAD/CONTRIBUTING.md)? - [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change? - [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting? - [x] Is your test running fine `brew test <formula>`, where `<formula>` is the name of the formula you're submitting? - [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)? Newly added dependencies are for creating PDF and HTML files, and for recognising file encoding.
|
Thanks for working on this, I figured it would be something fiddly that touches a ton of files. Do you mind submitting a pull request to Homebrew/formula-patches and referencing that, instead of the embedded patch? Thanks! |
|
Sure, no problem. I was actually thinking that's what needed to be done here; I just didn't know how that worked exactly. I will go have a look and figure it out. |
|
Just make a pull request with this patch in the |
|
PR at Homebrew/formula-patches opened. |
chenrui333
previously approved these changes
Nov 18, 2020
|
lgtm though. |
jonchang
previously approved these changes
Nov 18, 2020
jonchang
approved these changes
Nov 18, 2020
jonchang
pushed a commit
to Homebrew/formula-patches
that referenced
this pull request
Nov 18, 2020
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #65000 (comment)
Builds on #64842
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Newly added dependencies are for creating PDF and HTML files, and for file encoding recognition.