Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harlequin: remove mysql dependency #202790

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 30, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Dec 30, 2024
@cho-m cho-m marked this pull request as ready for review December 30, 2024 17:41
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Dec 30, 2024
@iMichka
Copy link
Member

iMichka commented Dec 30, 2024

Hey. I'm OK with the change, can you just give a little bit more context?

@cho-m
Copy link
Member Author

cho-m commented Dec 30, 2024

The Python library doesn't need C library,
https://github.com/mysql/mysql-connector-python/blob/8.4.0/mysql-connector-python/setup.py#L91-L92

MySQL driver written in Python which does not depend on MySQL C client
libraries and implements the DB API v2.0 specification (PEP-249).

Also, mysql (full DB installation) should rarely be used as dependency.

If C libraries are needed, then we would want mariadb-connector-c or mysql-client. Same reason we usually use libpq rather than postgresql@* dependency.

Copy link
Member

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 30, 2024
Merged via the queue into master with commit 478af15 Dec 30, 2024
23 checks passed
@BrewTestBot BrewTestBot deleted the harlequin-remove-mysql-dep branch December 30, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants