Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netatalk 4.0.8 (new formula) #202713

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rdmark
Copy link

@rdmark rdmark commented Dec 29, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>? (see caveat below)

Please note that brew audit --new netatalk throws non-compliance as per the below. However, the native macOS berkeley-db and openldap libraries are both unusable: The former lacks required symbols, and the latter (represented by LDAP.Framework) isn't fork safe while netatalk is a forking application.

brew audit --new netatalk                                                  
netatalk
  * Dependency 'berkeley-db' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.
  * Dependency 'openldap' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core perl Perl use is a significant feature of the PR or issue labels Dec 29, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@rdmark rdmark force-pushed the netatalk-4-0-8 branch 3 times, most recently from 4c5e0b4 to 8bb667f Compare December 29, 2024 15:02
@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 29, 2024
@rdmark
Copy link
Author

rdmark commented Dec 29, 2024

The remaining CI failures are triggered by the brew audit checks, AFAICT.

As mentioned in the summary, complying with them and using the macOS supplied libraries will break the software. Can these CI failures be ignored?

@carlocab carlocab added CI-skip-new-formulae Pass --skip-new to brew test-bot. CI-skip-new-formulae-strict Pass --skip-new-strictw to brew test-bot. and removed build failure CI fails while building the software labels Dec 29, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; a few comments.

Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 29, 2024
@rdmark rdmark force-pushed the netatalk-4-0-8 branch 2 times, most recently from 5e94138 to 3565ce2 Compare December 29, 2024 22:18
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 29, 2024
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 30, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 30, 2024
@rdmark rdmark force-pushed the netatalk-4-0-8 branch 3 times, most recently from 72a454a to 5e76486 Compare December 30, 2024 16:47
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 31, 2024
@rdmark rdmark force-pushed the netatalk-4-0-8 branch 2 times, most recently from c4ab373 to 74afc37 Compare January 1, 2025 16:58
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Jan 1, 2025
@rdmark rdmark force-pushed the netatalk-4-0-8 branch 2 times, most recently from f83a2b7 to 49b40d7 Compare January 1, 2025 21:33
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 1, 2025
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 2, 2025
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that worked. Just a few more comments to clean up and this should be ready to go. Please squash all your commits together as usual after applying the suggested changes.

Thanks!

Formula/n/netatalk.rb Outdated Show resolved Hide resolved
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 2, 2025
@carlocab carlocab enabled auto-merge January 2, 2025 17:41
Formula/n/netatalk.rb Outdated Show resolved Hide resolved
auto-merge was automatically disabled January 2, 2025 17:53

Head branch was pushed to by a user without write access

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 2, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 2, 2025
@carlocab carlocab enabled auto-merge January 2, 2025 17:57
auto-merge was automatically disabled January 2, 2025 19:13

Head branch was pushed to by a user without write access

@rdmark
Copy link
Author

rdmark commented Jan 2, 2025

@carlocab Thanks for all your help! I'm pleased that we got it working in the end.

FYI, I had to force-push the branch again because one of the macOS CI runners got flaky and posted a failure. Seems to have been an intermittent connection issue with the runner machine. Hopefully we get a green slate this time...

Edit: All jobs passed this time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-new-formulae Pass --skip-new to brew test-bot. CI-skip-new-formulae-strict Pass --skip-new-strictw to brew test-bot. new formula PR adds a new formula to Homebrew/homebrew-core perl Perl use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants