Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlyne: update test to remove expect dependency #202603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 28, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Dec 28, 2024
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Dec 28, 2024
@cho-m cho-m marked this pull request as ready for review December 28, 2024 01:02
@cho-m
Copy link
Member Author

cho-m commented Dec 29, 2024

Maybe rendering doesn't work on Intel runners.

Will probably try dumping the logs to stdout to see what is happening.

The original test really just started and killed after timeout as inlyne runs in a separate window so key presses don't work (i.e. send -- "q\r" didn't do anything)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant