Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

putty: add main putty executable #202594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

putty: add main putty executable #202594

wants to merge 2 commits into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 27, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

We've gotten some requests for main executable. Currently, putty only installs companion utilities.

Otherwise, should probably rename formula as putty doesn't install PuTTY.

@github-actions github-actions bot added the perl Perl use is a significant feature of the PR or issue label Dec 27, 2024
@cho-m
Copy link
Member Author

cho-m commented Dec 27, 2024

Probably want to figure out how to handle conflict with open-mpi before merge (bin/pterm)

Most Linux distros rename/move binary on open-mpi/prrte side though there isn't a consistent name, e.g.

  • Arch Linux - prrte-pterm1
  • Debian - pterm.openmpi2
  • Fedora - lib64/openmpi/bin/pterm3

Footnotes

  1. https://gitlab.archlinux.org/archlinux/packaging/packages/prrte/-/blob/main/PKGBUILD?ref_type=heads#L98

  2. https://salsa.debian.org/hpc-team/openmpi/-/commit/bc77bea52370b3ac4a786402016fbff6113ea978

  3. https://src.fedoraproject.org/rpms/prrte/blob/rawhide/f/prrte.spec#_106

@cho-m cho-m force-pushed the putty branch 2 times, most recently from 67e423b to b68d071 Compare December 28, 2024 21:55
@cho-m cho-m marked this pull request as ready for review December 28, 2024 21:56
@cho-m cho-m added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Dec 29, 2024
@cho-m cho-m added the maintainer feedback Additional maintainers' opinions may be needed label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. maintainer feedback Additional maintainers' opinions may be needed perl Perl use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant