Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/ci.yml: fix gathering of cask information #196675

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

bevanjkay
Copy link
Member

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@bevanjkay
Copy link
Member Author

@samford After seeing a few more runs of CI, the way the depencies and conflicts were being collected wasn't working as expected, as it was keeping the "" quotation around the variables. If you see it before the run expires, here's an example - https://github.com/Homebrew/homebrew-cask/actions/runs/12535648734/job/34957776751?pr=196675

I believe the changes I have here are working, just a linting error to fixup, but just checking if you have a better solution before moving ahead with this.

Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking if you have a better solution before moving ahead with this

Nope, nothing off the top of my head. Whatever works 🤷

It seems like whenever I go anywhere near a workflow file there's an issue with quotes in command arguments 😆

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@bevanjkay
Copy link
Member Author

It seems like whenever I go anywhere near a workflow file there's an issue with quotes in command arguments 😆

To be honest I started working on fixing the zizmor issues in my personal tap at one point, but put it on the backburner for this exact reason

@bevanjkay bevanjkay changed the title ci test .github/workflows/ci.yml: fix gathering of cask information Dec 30, 2024
@bevanjkay bevanjkay marked this pull request as ready for review December 30, 2024 04:12
@bevanjkay bevanjkay requested a review from samford December 30, 2024 04:12
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bevanjkay!

@bevanjkay bevanjkay merged commit 3197b31 into master Dec 30, 2024
9 checks passed
@bevanjkay bevanjkay deleted the ci-test branch December 30, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants