Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove # noqa: WPS comment #447

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Conversation

kat-git-hub
Copy link
Contributor

Отсутствие комментариев # noqa: WPS в проекте.

(venv) hexlet-friends % grep -r --include=*.py '# noqa: WPS' .

(venv) hexlet-friends %

@fey
Copy link
Collaborator

fey commented Jul 24, 2024

@kat-git-hub let's move away from WSP completely towards flake8
fyi @sgmdlt

@sgmdlt
Copy link
Collaborator

sgmdlt commented Jul 24, 2024

А зачем вы запушили всю директорию venv? Добавьте ее у себя в гитигнор и отправьте новый пр без нее

@kat-git-hub
Copy link
Contributor Author

Removed 'wemake-python-styleguide' from pyproject.toml and changed configuration in setup.cfg

@fey fey requested a review from sgmdlt July 31, 2024 09:27
@sgmdlt
Copy link
Collaborator

sgmdlt commented Jul 31, 2024

А можете подтянуть актуальный poetry.lock и запушить новый коммит?

@kat-git-hub
Copy link
Contributor Author

обновила poetry.lock

@sgmdlt
Copy link
Collaborator

sgmdlt commented Aug 2, 2024

Смотрите, CI падает, потому что в ней запускается линтер командой poetry run flake8, но самого линтера flake8 в зависимостях (pyproject, poetry.lock) нет. Вам нужно добавить его взамен удаленного wemake

@kat-git-hub
Copy link
Contributor Author

обновила зависимости - добавила flake8

@sgmdlt sgmdlt merged commit 0d632a9 into Hexlet:main Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants