Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designed the Courses page for student Section #43

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

Akanksha-Pant
Copy link

@Akanksha-Pant Akanksha-Pant commented Aug 21, 2020

Designed the Courses page for student Section
I have designed the courses page for the student section. I have tried to exactly replicate the page that was present on the website. The whole page has a similar UI to that of the webpage.I have also added a drawer to navigate to various other part of the app. This resolves #32

Screenshots

Screenshots of the proposed changes compared with the current version of the project
Image1
Image2
Image3

@Akanksha-Pant
Copy link
Author

Akanksha-Pant commented Aug 22, 2020

@helios1101 May I know what checks have failed so I can enhance my code?

@helios1101
Copy link
Collaborator

@Akanksha-Pant
Checkstyle errors have occured, not an issue.
Would you mind, adding a video of app in action.
Once, it's done we can proceed with reviewing changes.

@Akanksha-Pant
Copy link
Author

@helios1101 Hey You can click on the image to watch the video. I have tried to cover everything I can.

@helios1101
Copy link
Collaborator

Hi @Akanksha-Pant
Changes look great, would you mind adding the working video for the same, so that it becomes eligible for merge.
Thanks :)

@helios1101 helios1101 merged commit c1aff4c into HakinCodes:master Sep 2, 2020
@helios1101
Copy link
Collaborator

Show off your contributions in #28 and share with yopur friends.
Haapy Contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating the courses page for students section
2 participants