support LRU and LFU eviction #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDT3213
requested changes
Apr 29, 2023
database/database.go
Outdated
|
|
||
| //RandomDistinctKeysForEviction random get keys for eviction | ||
| func (db *DB) RandomDistinctKeysForEviction(limit int) []string { | ||
| if db.evictionPolicy.IsAllKeys() == false { |
There was a problem hiding this comment.
通常写作 if !db.evictionPolicy.IsAllKeys()
database/database.go
Outdated
| if db.evictionPolicy.IsAllKeys() == false { | ||
| keys := make([]string, limit) | ||
| i := 0 | ||
| db.data.ForEach(func(key string, val interface{}) bool { |
database/database.go
Outdated
| } | ||
|
|
||
| //RandomDistinctKeysForEviction random get keys for eviction | ||
| func (db *DB) RandomDistinctKeysForEviction(limit int) []string { |
eviction/lfu.go
Outdated
| return key | ||
| } | ||
|
|
||
| func GetLFUCounter(lfu int32) uint8 { |
eviction/lfu.go
Outdated
| } | ||
|
|
||
| // LFULogIncr counter increase | ||
| func LFULogIncr(counter uint8) uint8 { |
eviction/lfu.go
Outdated
| } | ||
|
|
||
| //LFUDecrAndReturn counter decr | ||
| func LFUDecrAndReturn(lfu int32) int32 { |
eviction/lfu.go
Outdated
| } | ||
|
|
||
| // LFUTimeElapsed Obtaining the time difference from the last time | ||
| func LFUTimeElapsed(ldt int32) int32 { |
There was a problem hiding this comment.
interface/eviction, eviction/lru, eviction/lfu 放入 database 包内即可，不需要公开到整个项目。
以及文件名拼错了 enviction_policy.go
database/database.go
Outdated
| } | ||
|
|
||
| //MakeEviction make a new mark about a key | ||
| func (db *DB) MakeEviction(keys []string) { |
There was a problem hiding this comment.
MakeEviction 函数应私有，作为 MakeXXX 却无返回值就很别扭。可以改为 initEvitionMark
database/database.go
Outdated
| } | ||
|
|
||
| //UpdateMark update mark about eviction | ||
| func (db *DB) UpdateMark(keys []string) { |
There was a problem hiding this comment.
- 函数应私有
- 这是 DB 的函数不是 evictionPolicy 的函数，函数名中带上 eviction 否则不知道更新的是什么 Mark.
UpdateMark -> updateEvictionMark
|
|
可以使用 |
有几个问题， |
|
evitction 应该写入 aof 并传播到 slave |
|
redis 在达到 maxmemory 时不会只淘汰一个 key, 参考 getMaxmemoryState 计算 mem_tofree |
|
请阅读 #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
因为config中没有内存设置，所以逐出方法没有使用