Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: foreground service cannot be started in background exception #1635

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: foreground service cannot be started in background exception #1635

merged 1 commit into from
Jan 6, 2025

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Dec 31, 2024 •
edited
Loading

Lokal reported this crash from an edgecase — Android

Easily reproducible, steps below

  1. Create an Outgoing call
  2. Put app to background
  3. Make callee accept the call
  4. Crash on caller: cant create foreground service from background

solution: create the service as soon as outgoing call state arrives

@santhoshvai santhoshvai merged commit bb82021 into main Jan 6, 2025
12 checks passed
@santhoshvai santhoshvai deleted the fg-service-crash-fix branch January 6, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristian-mkd kristian-mkd kristian-mkd approved these changes

@oliverlaz oliverlaz oliverlaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santhoshvai @oliverlaz @kristian-mkd