fix: add support for custom resolution of whether a message is ai generated #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +268 B (+0.02%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
isekovanic
commented
Dec 5, 2024
MartinCupela
reviewed
Dec 5, 2024
MartinCupela
reviewed
Dec 5, 2024
MartinCupela
reviewed
Dec 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2572 +/- ##
==========================================
- Coverage 82.97% 82.95% -0.02%
==========================================
Files 444 444
Lines 9221 9222 +1
Branches 2254 2254
==========================================
- Hits 7651 7650 -1
- Misses 1237 1239 +2
Partials 333 333 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
## [12.7.1](v12.7.0...v12.7.1) (2024-12-05) ### Bug Fixes * add support for custom resolution of whether a message is ai generated ([#2572](#2572)) ([54640ac](54640ac))
|
🎉 This PR is included in version 12.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
🎯 Goal
With the introduction of the AI feature in the SDK, we introduced a behaviour that checks for
message.ai_generatedand manages the UI based on that. This is very wrong, as this field (potentially) comes as a custom property and its place is not in the SDK. Instead, we introduce a new property calledisMessageAIGenerated, which is a factory function that controls the custom behaviour of figuring out whether a message is AI generated or not (which would vary from integration to integration). It also makes sure this isn't a breaking change for the SDK any longer.🛠 Implementation details
Provide a description of the implementation
🎨 UI Changes
Add relevant screenshots