feat: per-user channel pinning/archiving #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
force-pushed
the
feat/channel-pinning
branch
from
7af0a7d to
fa07dad
Compare
|
Size Change: +12.5 kB (+1.06%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2555 +/- ##
==========================================
- Coverage 82.95% 81.14% -1.82%
==========================================
Files 444 448 +4
Lines 9222 9460 +238
Branches 2254 2316 +62
==========================================
+ Hits 7650 7676 +26
- Misses 1239 1422 +183
- Partials 333 362 +29 ☔ View full report in Codecov by Sentry. |
arnautov-anton
force-pushed
the
feat/channel-pinning
branch
6 times, most recently
from
2b6dff9 to
8f1a777
Compare
| export const isChannelPinned = <SCG extends ExtendableGenerics>(channel: Channel<SCG>) => { | ||
| if (!channel) return false; | ||
|
|
||
| const member = channel.state.membership; |
There was a problem hiding this comment.
Hey!
I'm working on implementing pinning channels on our app.
I would just like to inform you that the channel.state.membership does not get updated when user pins/unpins a channel when a member.updated websocket notifications is received. Those this will not represent the "current" value of the pinned_at state.
There was a problem hiding this comment.
Hey, @michalvankodev, I know - I have another branch with appropriate change ready for a PR, it will be linked to this one and new version of the client will be required before releasing this feature. :)
There was a problem hiding this comment.
This one: GetStream/stream-chat-js#1409
arnautov-anton
changed the title
arnautov-anton
force-pushed
the
feat/channel-pinning
branch
from
1489843 to
3642fbb
Compare
MartinCupela
approved these changes
Dec 11, 2024
arnautov-anton
force-pushed
the
feat/channel-pinning
branch
from
e0ecde4 to
620e4a0
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
## [12.8.0](v12.7.1...v12.8.0) (2024-12-12) ### Features * per-user channel pinning/archiving ([#2555](#2555)) ([a51fad0](a51fad0))
|
🎉 This PR is included in version 12.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Integrate channel pinning and archiving within SDK.
This PR relies on: GetStream/stream-chat-js#1409 and GetStream/stream-chat-css#321